Modify

Opened 8 years ago

Closed 7 years ago

#650 closed defect (fixed)

Does this work with 0.10dev?

Reported by: shawn Owned by: coderanger
Priority: highest Component: PeerReviewPlugin
Severity: blocker Keywords:
Cc: Trac Release: 0.10

Description

I'm running Trac 0.10dev and having trouble installing it.

Attachments (4)

missing_content.gif (4.7 KB) - added by sier 8 years ago.
view_list.png (7.7 KB) - added by shawn 8 years ago.
picklist
select_list.png (20.2 KB) - added by shawn 8 years ago.
error when selected picklist
peerreview-0.10-workaround.txt (2.6 KB) - added by koji 8 years ago.
some workaround to work with trac 0.10

Download all attachments as: .zip

Change History (19)

comment:1 in reply to: ↑ description ; follow-up: Changed 8 years ago by sier@…

  • Priority changed from normal to highest
  • Severity changed from normal to blocker

Replying to shawn:

I'm running Trac 0.10dev and having trouble installing it.

I have the same problem. Upgrading the environment doesn't work. The need tables are not created.

comment:2 in reply to: ↑ 1 Changed 8 years ago by anonymous

Replying to sier@itsolution.ch:

Replying to shawn:

I'm running Trac 0.10dev and having trouble installing it.

I have the same problem. Upgrading the environment doesn't work. The need tables are not created.

I' removed try/except in upgrade_environment(), during upgrade now is showing this error message:

Command failed: to_sql

comment:3 Changed 8 years ago by Shawn

Any good news yet?

comment:4 Changed 8 years ago by Team5_Adam

This plugin was never run or tested with 0.10. When we released version 1.0, we believe that many of the bugs were worked out with the integration with Trac 0.9. There isn't any planned further development with the plugin from the original development team.

comment:5 Changed 8 years ago by coderanger

I am looking to deploy this on 0.10 as well. If it is alright with you I would be willing to take over maintenance of a 0.10 branch.

comment:6 Changed 8 years ago by coderanger

  • Owner changed from Team5 to coderanger
  • Status changed from new to assigned

A 0.10-compatible version should be uploaded shortly.

comment:7 follow-up: Changed 8 years ago by coderanger

Okay, the version in the 0.10 branch should be up and running.

Changed 8 years ago by sier

comment:8 in reply to: ↑ 7 ; follow-up: Changed 8 years ago by sier

Replying to coderanger:

Okay, the version in the 0.10 branch should be up and running.

Now I can upgrade the environment. But when I select a file for review, just the mime type is showing and not the content of file. I'm using 0.10b1.

comment:9 in reply to: ↑ 8 Changed 8 years ago by shawn

Replying to sier:

Replying to coderanger:

Okay, the version in the 0.10 branch should be up and running.

Now I can upgrade the environment. But when I select a file for review, just the mime type is showing and not the content of file. I'm using 0.10b1.

i'm getting the same thing.

Changed 8 years ago by shawn

picklist

Changed 8 years ago by shawn

error when selected picklist

comment:10 Changed 8 years ago by shawn

I'm also getting the following error by clicking on the peer review picklist. See attached image.

Changed 8 years ago by koji

some workaround to work with trac 0.10

comment:11 follow-up: Changed 8 years ago by anonymous

Using .10.2 -- I tried the workaround and everything, no go on creating a code review. I get:

Traceback (most recent call last):

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 387, in dispatch_request

dispatcher.dispatch(req)

File "/usr/lib/python2.3/site-packages/trac/web/main.py", line 245, in dispatch

req.display(template, content_type or 'text/html')

File "/usr/lib/python2.3/site-packages/trac/web/api.py", line 358, in display

data = self.hdf.render(template, form_token)

File "/usr/lib/python2.3/site-packages/trac/web/clearsilver.py", line 296, in render

injector.feed(template.render())

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 108, in feed

self.goahead(0)

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 148, in goahead

k = self.parse_starttag(i)

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 239, in parse_starttag

endpos = self.check_for_whole_start_tag(i)

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 314, in check_for_whole_start_tag

self.error("malformed start tag")

File "/var/tmp/python2.3-2.3.2-root/usr/lib/python2.3/HTMLParser.py", line 115, in error

raise HTMLParseError(message, self.getpos())

HTMLParseError: malformed start tag, at line 250, column 36

Any ideas?

comment:12 in reply to: ↑ 11 Changed 8 years ago by coderanger

Replying to anonymous:

Using .10.2 -- I tried the workaround and everything, no go on creating a code review. I get: HTMLParseError: malformed start tag, at line 250, column 36

As of 0.10.1, Trac validates the HTML produced by plugins. This plugin produces awful markup. At this point the whole thing should probably just be reworked from scratch for 0.11/Genshi.

comment:13 Changed 8 years ago by winnie

when I select a file for review, just the mime type is showing and not the content of file.

i'm getting the same thing. when it would be fixed?or which version could fix it? thanks!

comment:14 Changed 8 years ago by mikechml

(In [2270]) fixes #938, #1035 refs #650

Moved large portions of javascript to external files to avoid parser errors, and keep it tidy. Fixes for preview_to_hdf. Should now work with 0.10

comment:15 Changed 7 years ago by sontek

  • Resolution set to fixed
  • Status changed from assigned to closed

This is working for 0.10.4

Add Comment

Modify Ticket

Action
as closed The owner will remain coderanger.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.