Modify

Opened 8 years ago

Closed 21 months ago

#655 closed enhancement (wontfix)

Does this work with .10dev (svn)

Reported by: vinay Owned by: nik4536
Priority: normal Component: HttpLoginViaRedirectPatch
Severity: normal Keywords:
Cc: vinay@…, jorge.vargas@… Trac Release: 0.10

Description

Since I run a production server, I don't have the ability to take down the system and patch it and see if it works. I would like to know if this works with .10dev. If not, is there a solution that does?

If I do get the chance to test it against a .10dev trac installation, I'll update the ticket here to reflect that.

Attachments (2)

httploginviaredirectpatch-0.10.patch (3.0 KB) - added by JamesMills 8 years ago.
Patch for 0.10
auth.diff (1.8 KB) - added by anonymous 7 years ago.
Patch for 0.10.3

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by JamesMills

Hi,

I've attached a patch to make this work with 0.10

See: attachment:httploginviaredirectpatch-0.10.patch

Could someone please try to make this
also work with the AuthFormPlugin :)

Changed 8 years ago by JamesMills

Patch for 0.10

comment:2 Changed 8 years ago by anonymous

I just try out this patch agains 0.10.3 with tracd

I believe the standalone.py file doesn't needs to be patch anymore with standalone.diff
since the split in standalone.py is taking out the hardcoded comparison agains /login

but for some reason the redirect is not working, here is my tracd output in debug mode

localhost.domain - - [06/Jan/2007 13:55:43] "GET /trac/ HTTP/1.1" 403 -
localhost.domain - - [06/Jan/2007 13:55:59] "GET /trac/login/timeline HTTP/1.1" 401 -
01:55:59 PM Trac[main] WARNING: 404 Not Found (No handler matched request to /login/timeline)
localhost.domain - - [06/Jan/2007 13:55:59] "GET /trac/login/timeline HTTP/1.1" 404 -

as you can see there is no trace of self.env.log.debug("req.path_info = %s" % req.path_info) so I believe it's not getting process correctly.

comment:3 Changed 8 years ago by anonymous

  • Cc jorge.vargas@… added

Changed 7 years ago by anonymous

Patch for 0.10.3

comment:4 Changed 7 years ago by anonymous

I patched HttpLoginViaRedirectPatch with attachment:ticket:655:httploginviaredirectpatch-0.10.patch but it does not work with trac 0.10.3. I have attached (attachment:ticket:655:auth.diff) a version of HttpLoginViaRedirectPatch that works.

comment:5 Changed 21 months ago by rjollos

  • Resolution set to wontfix
  • Status changed from new to closed

Closing since this patch is for 0.9/0.10, and both are long dead now.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from nik4536. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.