Modify

Opened 4 years ago

Last modified 4 years ago

#6917 new defect

Tabs and regular spaces? Really?

Reported by: bellaire Owned by: optilude
Priority: low Component: GoogleChartPlugin
Severity: minor Keywords:
Cc: Trac Release: 0.11

Description

The source code mixes tabs and spaces in charting.py. Specifically, the indentation level appears to be 4 spaces, but where the indentation is at least a multiple of 8, tabs are used first, and then spaces to do a "half-tab". This mixing is horrible on others trying to read and patch your code, or at least it was for me. Please switch to either all tabs or all spaces.

See PEP 8 -- Style Guide for Python Code, specifically the following:

Tabs or Spaces?

Never mix tabs and spaces.

Attachments (0)

Change History (1)

comment:1 Changed 4 years ago by optilude

I no longer maintain this plugin. It's open source, though, do with what you wish.

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.