Modify

Opened 14 years ago

Closed 6 months ago

#7027 closed enhancement (fixed)

HudsonTrac branch for 0.11

Reported by: Christian Boos Owned by: Dirk Stöcker
Priority: normal Component: HudsonTracPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Hello,

As I'm starting to use Hudson, I naturally wanted to give a try to the Hudson Trac plugin. It works well, great work!

However, the current code is in source:hudsontracplugin/0.10, and while it works with 0.11 and up, it really feels too "0.10" for my taste ;-)

So I've refreshed it to make it work with 0.11 only, adapting the coding style to be a bit more like the Trac:TracDev/CodingStyle as well, and it would be nice to reintegrate that in a 0.11 branch.

This is in preparation for likely further enhancements.

(and btw, TracHacks itself also really feels too 0.10 for my taste ;-) )

Attachments (1)

hudsontracplugin-0.11.patch.gz (3.5 KB) - added by Christian Boos 14 years ago.
copy of source:hudsontrac/0.10@7307 to hudsontrac/0.11 + clean-ups, no functional changes

Download all attachments as: .zip

Change History (10)

Changed 14 years ago by Christian Boos

copy of source:hudsontrac/0.10@7307 to hudsontrac/0.11 + clean-ups, no functional changes

comment:1 Changed 14 years ago by Christian Boos

Sorry, I had to .gzip it, as the patch was rejected as spam (some of the removed lines contained the <a href= pattern).

comment:2 Changed 14 years ago by roadrunner

Thanks for the input.

However, there are still various folks running 0.10 out there, and I don't feel like maintaining two branches. So while I may incorporate some of the style changes, I don't think I'll do any of the changes that break 0.10 compatibility yet. Sorry.

comment:3 Changed 14 years ago by Christian Boos

As you wish. I have upcoming changes on top of this, and a 0.12 branch coming next (with i18n support).

Tell me if it's OK for you if I maintain those branches here (on TracHacks) or if I should put them elsewhere.

comment:4 Changed 14 years ago by roadrunner

(In [7911]) Pulled in some formatting fixes and code-style improvements from the patch in #7027, plus made some addition style fixes to better align with the trac coding guidelines. The changes that break 0.10 compatibility have been left out for now.

Addresses #7027.

comment:5 in reply to:  3 Changed 14 years ago by roadrunner

Replying to cboos:

As you wish. I have upcoming changes on top of this, and a 0.12 branch coming next (with i18n support).

Tell me if it's OK for you if I maintain those branches here (on TracHacks) or if I should put them elsewhere.

Can you elaborate on the changes you have in mind? Besides the i18n support in 0.12 I'm not aware of any features in 0.11 or 0.12 that would be of any particular interest for this plugin.

comment:6 Changed 14 years ago by Christian Boos

It's not that much about specific features I could use, only that I wanted a "clean" base to start adding new features, without having to take the 0.10 legacy into account.

I think I'll also add some kind of summary page, reachable from the Build tab, and this will be made from a Genshi template, not Clearsilver.

So far I have added the following:

  • "author" information
  • optionally show in-progress builds
  • i18n support in a 0.12 branch

See http://github.com/cboos/trachacks-hudsontracplugin

comment:7 Changed 13 years ago by roadrunner

Btw., I have pulled in (modified versions of) your in-progress builds and author information changes (see r9469 and r9471, respectively). Many thanks.

comment:8 Changed 6 months ago by Ryan J Ollos

Owner: changed from roadrunner to Dirk Stöcker
Status: newassigned

comment:9 Changed 6 months ago by Dirk Stöcker

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Dirk Stöcker.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.