Modify

Opened 4 years ago

Closed 4 years ago

#7085 closed defect (fixed)

[PATCH] breaks when trac site is accessed via a link with a target

Reported by: anonymous Owned by: vnaum
Priority: normal Component: CcSelectorPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

The link (within our website) to my group's trac site uses target="_blank" to open trac in a new window/tab. When that is done and the parent window/tab is left around, cc_selector breaks with:

Error: Permission denied for <https://[parent website]> to get property Window.document from <[parent website]>.
Source File: https://[trac site]/chrome/cc_selector/cc_selector.js
Line: 95

(tested in firefox 3.5.9 and 3.6.4)

The 1st "if" (line 93) in guess_cc_field() seems to assume there will only be a window.opener within the pop-up window? Our setup is a case where that's not true.

Works fine if we close the parent window/tab before going to "New Ticket", but... need to detect if you're in the pop-up before trying to access window.opener. patch attached.

Attachments (1)

cc_selector.diff (385 bytes) - added by anonymous 4 years ago.
patch for pre-existing opener bug

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by anonymous

patch for pre-existing opener bug

comment:1 Changed 4 years ago by anonymous

  • Summary changed from breaks when trac site is accessed via a link with a target to [PATCH] breaks when trac site is accessed via a link with a target

comment:2 Changed 4 years ago by vnaum

  • Resolution set to fixed
  • Status changed from new to closed

(In [7933]) better main window detection
(closes #7085)

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.