Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7225 closed defect (fixed)

[patch] Milestones don't show up in calendar if their due time is not 00:00:00 (h:m:s)

Reported by: delsauce@… Owned by: hasienda
Priority: normal Component: WikiTicketCalendarMacro
Severity: major Keywords: 0.11 0.12 milestone
Cc: rjollos Trac Release: 0.11

Description

Not sure why the due time of milestones in our install is not 00:00:00, but they are. When this is the case, no milestones will show up in the calendar because the SELECT statement in the macro that searches for the milestones is looking for an exact time match.

I modified the query so that the milestone time isn't taken into consideration (the entire day will match). Here is the line of code that was changed:

 cursor.execute("""
                        SELECT name
                          FROM milestone
                         WHERE due >= %s and due < %s
                    """, (duedatestamp,duedatestamp_eod, ))

Attachments (0)

Change History (6)

comment:1 Changed 4 years ago by rjollos

  • Cc rjollos added
  • Owner changed from rjollos to hasienda

comment:2 Changed 4 years ago by rjollos

Based on the number of tickets opened, this certainly seems to be a popular macro!

comment:3 Changed 4 years ago by hasienda

  • Keywords 0.11 0.12 milestone added
  • Severity changed from normal to major
  • Status changed from new to assigned
  • Summary changed from Milestones don't show up in calendar if their due time is not 00:00:00 (h:m:s) to [patch] Milestones don't show up in calendar if their due time is not 00:00:00 (h:m:s)

Glad you found it. I was already suspecting a bug in the milestone part, since my test milestones did never show up as well.

I confirm that this flaw exist not only in the current version from 0.11 branch but up from the first publicly released version up to the latest development version in trunk. In short: this never work, despite all data necessary (duedatestamp, duedatestamp_eod) was prepared and in place.

I've build a fixed version of trunk with the suggested code improvement and it's working well. I'll merge the change to all branches now. Expect a new maintenance release tonight.

comment:4 Changed 4 years ago by hasienda

Let's aim at fixing this within one hour after ticket creation to account for the high popularity. :-)

comment:5 Changed 4 years ago by hasienda

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8108]) WikiTicketCalendarMacro: Improve milestone query to actually make it work right, closes #7225.

This is a long standing flaw persisting from the earliest version up to current trunk.
Thanks to delsauce@… for report and suggested code change.

comment:6 Changed 4 years ago by delsauce@…

No worries-- glad to help. Thanks for resolving so quickly.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.