Modify

Opened 4 years ago

Closed 4 years ago

#7226 closed defect (fixed)

[patch] march has error in navigation link

Reported by: David.Byrne@… Owned by: hasienda
Priority: normal Component: WikiTicketCalendarMacro
Severity: major Keywords: 0.11 0.12 navigation link
Cc: rjollos Trac Release: 0.12

Description

There is a bug in the logic that detects when to add 9 months for the "Turn up". On line 497 it should read:

if month < 4:

not:

if month < 3:

I'm also not sure that "Turn up" makes as much sense as "Move to", "Change to", or some other phrase.

Attachments (0)

Change History (3)

comment:1 Changed 4 years ago by rjollos

  • Cc rjollos added; anonymous removed
  • Owner changed from rjollos to hasienda
  • Summary changed from Month of march errors off. to Month of march errors off

comment:2 Changed 4 years ago by hasienda

  • Keywords 0.11 0.12 navigation link added
  • Status changed from new to assigned
  • Summary changed from Month of march errors off to [patch] march has error in navigation link

I confirm that this is a bug that was introduced with the 3rd set of navigation links and is valid for all versions but the old 0.10 branch.

The off-by-one due to wrong test condition for 3-month-back-nav link will hit every march. Fixed revisions will be release tonight. Thank you very much for testing.

May I ask for another ticket regarding the disputed wording for nav link tooltip, please? This is unrelated to the aforementioned bug, so it would help for better issue tracking

Besides I'm certainly open to get well-educated advice from native English speakers. Actually I made this up on my own to replace the ubiquitous 'Go to' by suggesting the turn up a calendar book page to be similar. But I might have been wrong.

comment:3 Changed 4 years ago by hasienda

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8109]) WikiTicketCalendarMacro: Correct test condition for 3-months-back nav link, closes #7226.

Wrong test produced invalid navigation link with 'month=0', that raised an error instead of jumping back 3 months from every March. Thanks to David Byrne for report and suggested code change.

Add Comment

Modify Ticket

Action
as closed The owner will remain hasienda.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.