Changes between Initial Version and Version 5 of Ticket #7229


Ignore:
Timestamp:
May 20, 2014, 9:51:50 PM (10 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #7229

    • Property Priority changed from normal to high

  • Ticket #7229 – Description

    initial v5  
    11I've upgraded my buildbot install to the latest (0.8).  I had to make a change on line 87 from:
    2                                 laststatus=lastbuild[5]
     2{{{#!python
     3laststatus=lastbuild[5]
     4}}}
    35to:
    4                                 laststatus=lastbuild[6]
     6{{{#!python
     7laststatus=lastbuild[6]
     8}}}
    59
    610This would only work with buildbot 0.8.  What might be best is to include a configuration option so that this could be updated more easily.  Maybe something like:
    711
    8         def get_status_location(self):
    9                 status_offset=self.config.get("buildbot", "status_pos")
    10                 if status_offset:
    11                         try:
    12                                 return int(status_offset)
    13                         except ValueError:
    14                                 return 5
    15                 else:
    16                         return 5
     12{{{#!python
     13def get_status_location(self):
     14    status_offset=self.config.get("buildbot", "status_pos")
     15    if status_offset:
     16        try:
     17            return int(status_offset)
     18        except ValueError:
     19            return 5
     20    else:
     21        return 5
     22}}}
    1723
    1824and then using this to find the status instead of hard-coding 5 or 6 on line 87.
    1925
    2026The buildbot team changed the xmlrpc interface to set the return from:
    21             answer = (builder_name,
    22                       build.getNumber(),
    23                       build_end,
    24                       branch,
    25                       revision,
    26                       Results[build.getResults()],
    27                       build.getText(),
    28                       )
     27{{{#!python
     28answer = (builder_name,
     29          build.getNumber(),
     30          build_end,
     31          branch,
     32          revision,
     33          Results[build.getResults()],
     34          build.getText(),
     35          )
     36}}}
    2937to:
    30             answer = (builder_name,
    31                       build.getNumber(),
    32                       build_start,
    33                       build_end,
    34                       branch,
    35                       revision,
    36                       Results[build.getResults()],
    37                       result,
    38                       reasons,
    39                       )
    40 
    41 By adding the build_start as the new [2] position, it moved the Results from the [5] to the [6] position.
     38{{{#!python
     39answer = (builder_name,
     40          build.getNumber(),
     41          build_start,
     42          build_end,
     43          branch,
     44          revision,
     45          Results[build.getResults()],
     46          result,
     47          reasons,
     48          )
     49}}}
     50By adding the build_start as the new ![2] position, it moved the Results from the ![5] to the ![6] position.