Modify

Opened 14 years ago

Closed 12 years ago

Last modified 12 years ago

#7291 closed defect (wontfix)

Admin panel should be visible just to WIKI_ADMIN users

Reported by: Mitar Owned by: Noah Kantrowitz
Priority: normal Component: WikiRenamePlugin
Severity: normal Keywords:
Cc: Mitar Trac Release: 0.11

Description

Admin panel should be visible just to WIKI_ADMIN users as otherwise users without other privileges have just this admin panel available. But admin panel is used also while renaming the page so it is hard to get rid of it. Because of this I made a small hack for which is patch here:

--- web_ui.py.orig	2010-06-24 16:54:54.000000000 +0200
+++ web_ui.py	2010-06-24 17:04:33.000000000 +0200
@@ -24,7 +24,7 @@
     # IAdminPanelProvider methods
     def get_admin_panels(self, req):
         perm = req.perm('wiki')
-        if 'WIKI_RENAME' in perm or 'WIKI_ADMIN' in perm:
+        if ('WIKI_RENAME' in perm and 'redirect' in req.args) or 'WIKI_ADMIN' in perm:
             yield ('general', 'General', 'wikirename', 'Wiki Rename')
             
     def render_admin_panel(self, req, cat, page, path_info):

Attachments (0)

Change History (2)

comment:1 Changed 12 years ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

The plugin is deprecated since there is now support in the Trac core.

comment:2 Changed 12 years ago by Ryan J Ollos

If you'd like to apply patches I can provide you commit access.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Noah Kantrowitz.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.