Modify ↓
Opened 3 years ago
Closed 3 years ago
#7303 closed defect (fixed)
UI should be consistent with custom query filters
| Reported by: | CuriousCurmudgeon | Owned by: | CuriousCurmudgeon |
|---|---|---|---|
| Priority: | normal | Component: | BatchModifyPlugin |
| Severity: | normal | Keywords: | ui |
| Cc: | Trac Release: | 0.11 |
Description
The current plugin UI predates the built-in Trac custom query UI. Update the batch modify section to use something similar. Users should be able to easily add the fields they want to modify the same way they add filters to the query.
Attachments (0)
Change History (20)
comment:1 Changed 3 years ago by CuriousCurmudgeon
comment:2 Changed 3 years ago by CuriousCurmudgeon
- General code cleanup
- Moved most of the jQuery code to batchmod.js. There is still a little bit left that is built with Genshi. That won't be needed by the time I'm done though.
- Commented most of the jQuery code. It's now clear what each block is doing.
- Removed some apparently useless code dealing with columns.
comment:3 Changed 3 years ago by CuriousCurmudgeon
- Status changed from new to assigned
comment:4 Changed 3 years ago by CuriousCurmudgeon
comment:5 Changed 3 years ago by CuriousCurmudgeon
comment:6 Changed 3 years ago by CuriousCurmudgeon
comment:7 Changed 3 years ago by CuriousCurmudgeon
comment:8 Changed 3 years ago by CuriousCurmudgeon
comment:9 Changed 3 years ago by CuriousCurmudgeon
comment:10 Changed 3 years ago by CuriousCurmudgeon
comment:11 Changed 3 years ago by CuriousCurmudgeon
- Made all element ids and names consistent. All start with "batchmod" now.
- Setting a resolution automatically sets the status to closed.
- Setting a status requires a resolution be set client-side
- At radio group must have an element selected.
- All validation is displayed to the user in spans next to the inputs.
comment:12 Changed 3 years ago by CuriousCurmudgeon
comment:13 Changed 3 years ago by CuriousCurmudgeon
comment:14 Changed 3 years ago by CuriousCurmudgeon
comment:15 Changed 3 years ago by CuriousCurmudgeon
comment:16 Changed 3 years ago by CuriousCurmudgeon
comment:17 Changed 3 years ago by CuriousCurmudgeon
comment:18 Changed 3 years ago by CuriousCurmudgeon
- Fixed a typo that was causing elements to be added incorrectly to the page in IE. I can't believe it even worked in Firefox.
- Fixed a bug that was allowing the form to submit even if a resolution was required.
- Converted all tabs to spaces.
- Ran it through jslint and made recommended fixes.
comment:19 Changed 3 years ago by CuriousCurmudgeon
comment:20 Changed 3 years ago by CuriousCurmudgeon
- Resolution set to fixed
- Status changed from assigned to closed
Note: See
TracTickets for help on using
tickets.


(In [8164]) refs #7303