Ticket #7303 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

UI should be consistent with custom query filters

Reported by: CuriousCurmudgeon Assigned to: CuriousCurmudgeon
Priority: normal Component: BatchModifyPlugin
Severity: normal Keywords: ui
Cc: Trac Release: 0.11

Description

The current plugin UI predates the built-in Trac custom query UI. Update the batch modify section to use something similar. Users should be able to easily add the fields they want to modify the same way they add filters to the query.

Attachments

Change History

06/28/10 03:46:28 changed by CuriousCurmudgeon

(In [8164]) refs #7303

  • Created a new brach for me to mess around with changing the UI.
  • Added a separate javascript file for client-side adding of fields to modify, similar to adding query filters.
  • Playing around with a field dropdown.

06/30/10 02:03:59 changed by CuriousCurmudgeon

(In [8170]) refs #7303

  • General code cleanup
  • Moved most of the jQuery code to batchmod.js. There is still a little bit left that is built with Genshi. That won't be needed by the time I'm done though.
  • Commented most of the jQuery code. It's now clear what each block is doing.
  • Removed some apparently useless code dealing with columns.

06/30/10 02:05:45 changed by CuriousCurmudgeon

  • status changed from new to assigned.

06/30/10 02:30:32 changed by CuriousCurmudgeon

(In [8171]) refs #7303

  • Added some notes to remind myself what needs to happen when a field is added.

06/30/10 21:27:18 changed by CuriousCurmudgeon

(In [8177]) refs #7303

  • Started adding elements to the page on change. This is also actually a 0.12 version now. Need to move the branch.

06/30/10 21:34:19 changed by CuriousCurmudgeon

(In [8178]) refs #7303

  • Moved branch to 0.12.

06/30/10 23:03:14 changed by CuriousCurmudgeon

(In [8179]) refs #7303

  • Made a mess appending fields. Selecting a field now adds a new select and a remove button. They are not formatted correctly and have no behavior though.

07/01/10 22:24:26 changed by CuriousCurmudgeon

(In [8195]) refs #7303

  • Can now add all fields through dropdown.
  • Removed old UI.
  • Added new stylesheet to match look of fiters.
  • Filtered created and modified fields from dropdown.
  • Bumped version for this branch to 0.7.0a1

07/01/10 22:58:16 changed by CuriousCurmudgeon

(In [8196]) refs #7303

  • Plugin now handles the new way values are passed.

07/03/10 04:26:02 changed by CuriousCurmudgeon

(In [8203]) refs #7303

  • Created a separate BatchMod? namespace to avoid collisions.

07/04/10 00:04:08 changed by CuriousCurmudgeon

(In [8207]) refs #7303

  • Made all element ids and names consistent. All start with "batchmod" now.
  • Setting a resolution automatically sets the status to closed.
  • Setting a status requires a resolution be set client-side
  • At radio group must have an element selected.
  • All validation is displayed to the user in spans next to the inputs.

07/04/10 01:32:01 changed by CuriousCurmudgeon

(In [8208]) refs #7303

  • Setting the status to something other than 'closed' will remove the resolution if there is one.
  • Moved all JavaScript? back inside of the jQuery ready event.

07/04/10 02:03:37 changed by CuriousCurmudgeon

(In [8209]) refs #7303

  • "Add Field" dropdown is in alphabetical order.
  • Input fields are added in alphabetical order as well.

07/04/10 02:24:35 changed by CuriousCurmudgeon

(In [8210]) refs #7303

  • Added some comments.

07/04/10 22:10:19 changed by CuriousCurmudgeon

(In [8213]) refs #7303

  • Refactored actual batch modification code into a separate class. This should make it easier to write some tests.

07/06/10 02:10:45 changed by CuriousCurmudgeon

(In [8219]) refs #7303

  • Wrote some unit tests for the helper methods.
  • This is my first foray into Python unit testing so I expect mistakes will be made.

07/06/10 21:49:40 changed by CuriousCurmudgeon

(In [8222]) refs #7303

  • Merged work from ui_sandbox branch into 0.12 trunk.
  • Still need to backport all of this to work on 0.11.x

07/07/10 20:17:20 changed by CuriousCurmudgeon

(In [8227]) refs #7303

  • Fixed a typo that was causing elements to be added incorrectly to the page in IE. I can't believe it even worked in Firefox.
  • Fixed a bug that was allowing the form to submit even if a resolution was required.
  • Converted all tabs to spaces.
  • Ran it through jslint and made recommended fixes.

07/07/10 20:51:19 changed by CuriousCurmudgeon

(In [8228]) refs #7303

  • Merged changes over 0.11 trunk.
  • Uncommented call to .detach() and changed it to .remove() in both versions. .detach() does not exist in JQuery 1.2.6 and .remove() is a better fit anyways.
  • Backported necessary code from trac.js to batchmod.js in 0.11 version.

07/07/10 21:13:58 changed by CuriousCurmudgeon

  • status changed from assigned to closed.
  • resolution set to fixed.

Add/Change #7303 (UI should be consistent with custom query filters)




Change Properties
Action