Modify

Opened 4 years ago

Last modified 4 years ago

#7349 new defect

Plugin does not filter private comments in notification email

Reported by: mhenke Owned by: mhenke
Priority: highest Component: PrivateCommentPlugin
Severity: critical Keywords: filter ticket notification
Cc: doki_pen Trac Release: 0.12

Description

The Plugin only filters the ticket page to remove private comments. Email notification is not filtered.

I tried MailToTracPlugin which promises to make it possible to filter the notifications but it did not work. The only way I know to enable an email filter is via a change at the trac core. The attached trac.ticket.notification checks the status of a comment before it sets the email text. If the comment is private it replaces the comment text with a neutral 'The comment is private'. The special permission is not checked so users with this permission have to click at the link at the lower end of the email.

I'd like to get rid of the core changes so if there is anybody who knows how to filter notifications via plugin -> please help me :)

Attachments (2)

notification.py (14.5 KB) - added by mhenke 4 years ago.
notification_patch.patch (1.7 KB) - added by mhenke 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by mhenke

Changed 4 years ago by mhenke

comment:1 Changed 4 years ago by hasienda

  • Cc doki_pen added; anonymous removed
  • Keywords filter ticket notification added

TracAnnouncer aka AnnouncerPlugin is going through fundamental code re-arrangements and a re-design of the configuration web-UI parts. Nevertheless I believe, this is the way to go for notifications in Trac. There even is a yet not very busy supported proposal to officially replace current TracNotification system, that is badly in need of some maintenance and lacks a lot of functionality already existing in AnnouncerPlugin. (So why re-invent the wheel?)

Creating a custom filter should be possible via an mandatory filter extension, and we will certainly create a suitable ExtensionPoint in TracAnnouncer, if it's not already there today.

comment:2 Changed 4 years ago by mhenke

Thanks for informing me about AnnouncerPlugin / TracAnnouncer. As soon as I have time I will look into it.

Add Comment

Modify Ticket

Action
as new The owner will remain mhenke.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.