Opened 14 years ago

Last modified 12 years ago

#7366 closed defect

Installing plugin crashes website — at Version 5

Reported by: anonymous Owned by: Ryan J Ollos
Priority: highest Component: ContactsPlugin
Severity: blocker Keywords:
Cc: Trac Release: 0.11

Description (last modified by Ryan J Ollos)

I installed this plugin using easy_install on Trac 0.12 and I get the following error when I try to trac-admin upgrade:

Contacts needs an upgrade
 * Upgrading db
TypeError: not all arguments converted during string formatting

I can no longer access my site.

Change History (5)

comment:1 Changed 14 years ago by Ulf

Hi, to recover your site you could disable the plugin in your trac.ini file ([ENV]/conf/trac.ini).

You could also init the db for contacts by hand:

It seems something is wrong with the db init script. I fixed it by creating the contacts table manually:

CREATE TABLE [contact] (id int UNIQUE,first text,last text,position text,email text,phone text)

...and changing the value of an entry of the system table from 0 to 1 (contacts_version)

You could use an SQLite management tool to do so. After that the plugin works...

comment:2 Changed 13 years ago by anonymous

So what in blazes does this mean? Basically this plugin is broken before it's even installed? Why is it here? I have tried to install it and have not been able to get it working yet. I am not an sqlite master, just need to use trac with a contact mechanism.

comment:3 Changed 12 years ago by JJ

This really should be taken off the site until it is fixed. I tried to install it for one of my test environments, and it completely shut down our main Trac site. Not cool at all...

comment:4 in reply to:  3 Changed 12 years ago by Ryan J Ollos

Owner: changed from CM Lubinski to Ryan J Ollos
Status: newassigned

Replying to JJ:

This really should be taken off the site until it is fixed.

I'm not saying you are wrong, but the community is set up to allow anyone to make their code available, and there is no obligation for them to support it. This is effectively no different than navigating to someone's repository on GitHub, and trusting that their code is good without knowing anything about the person.

Eventually, I want trac-hacks to be better than this situation I described with GitHub, and I think you have a right to expect that there is some vetting of the code that is available here. Well, in fact there is some information available already - you should review the list of open issues for a plugin before you install it. Eventually though, I want to improve the user experience, by requiring all code to be licensed, and developing some sort of quality or confidence index for code. We are just not currently setup to do anything about this, and it will take some time to get there.

I tried to install it for one of my test environments, and it completely shut down our main Trac site. Not cool at all...

If I may make a suggestion from experience, you really need to have a staging site for testing out these plugins before promoting them. The reality is just that this is all open source code that hasn't been vetted, and precautions need to be taken.

I'll see if I can get this working for you now.

comment:5 Changed 12 years ago by Ryan J Ollos

Description: modified (diff)
Note: See TracTickets for help on using tickets.