Modify

Opened 4 years ago

Closed 7 months ago

Last modified 7 months ago

#7397 closed enhancement (fixed)

[Patch] Restrict view of developer page by adding a permission

Reported by: srl@… Owned by: anonymous
Priority: normal Component: TracDeveloperPlugin
Severity: normal Keywords:
Cc: hasienda Trac Release: 0.12

Description

patch to add a DEVELOPER_VIEW permission.

The reason is, 'Developer Tools' is confusing to users, as it has nothing to do with our site. So I hide it from non-admins.

Attachments (1)

developer.patch (1.6 KB) - added by Srl295 4 years ago.
the patch (forgot I had a login at create)

Download all attachments as: .zip

Change History (15)

Changed 4 years ago by Srl295

the patch (forgot I had a login at create)

comment:1 Changed 4 years ago by rjollos

  • Summary changed from Restrict view of developer page with permission to [Patch] Restrict view of developer page by adding a permission

comment:2 Changed 4 years ago by rjollos

This patch does not seem like it is all that useful since one typically (and good practice probably suggests never) develops on a production Trac instance that others have access to. Can you suggest another use case for this that I might not be thinking of?

comment:3 Changed 4 years ago by rjollos

  • Owner changed from otaku42 to osimons

comment:4 Changed 4 years ago by Srl295

I don't primarily develop on a production trac server, however, these tools are useful for problem resolution at times.

At the least, it would help one create more realistic screen shots.

comment:5 Changed 3 years ago by lkraav

i support this patch.

comment:6 Changed 3 years ago by lkraav

debugger.py:post_process_request also requires a DEVELOPER_VIEW permissions check for if 'debug' not in req.args

comment:7 Changed 3 years ago by rjollos

  • Cc hasienda added

The patch looks good to me. If an experienced Trac developer can sign off on it, I'd be happy to push it to the repository.

comment:8 follow-up: Changed 3 years ago by hasienda

While generally I support your position, I see Steven's point too.

Can't harm to have this in, but in addition to Leho's comment you should ensure that the output of get_permission_actions is always a list, or the list of permissions could get messed up badly. I think I saw this happen when tampering with adding permissions to another plugin on my own: I got multiple single-char permissions instead of one.

comment:9 in reply to: ↑ 8 Changed 3 years ago by rjollos

Replying to hasienda:

Can't harm to have this in, ...

That was my thought too after reading the discussion that followed. I'm fairly sure this plugin is currently un-maintained. I think I reassigned this ticket to Osimons early on thinking he was maintaining it, but had a discussion with him later and he said that's not the case.

I'll leave this for a few days to see if anyone has comments about the maintenance status.

Last edited 7 months ago by rjollos (previous) (diff)

comment:11 Changed 22 months ago by rjollos

  • Owner changed from osimons to olemis

comment:12 Changed 7 months ago by olemis

  • Owner changed from olemis to anonymous
  • Status changed from new to assigned

comment:13 Changed 7 months ago by olemis

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13524:

TracDeveloperPlugin [ fixes #7397 ] : Add DEVELOP action to control access to developer views

version => 0.3.0

comment:14 Changed 7 months ago by rjollos

DEVELOP as an action name seems a bit inconsistent with the naming conventions of the other action names. What about TRAC_DEVELOP?

comment:15 Changed 7 months ago by olemis

In 13525:

TracDeveloperPlugin [ refs #7397 ] : Permission action DEVELOP => TRAC_DEVELOP

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from anonymous. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.