Ticket #7426 (new enhancement)

Opened 3 years ago

Last modified 4 months ago

Dynamicity of Trac (Show number of registered users)

Reported by: anonymous Assigned to: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: admin panel
Cc: Trac Release: 0.11

Description

show the number of registered users on top of main page

Attachments

ReportPage.png (9.3 kB) - added by rjollos on 12/12/12 23:33:08.
th7426-r12500-1.patch (1.2 kB) - added by rjollos on 12/31/12 19:29:11.
Patch against r12500 of the trunk.

Change History

08/03/10 22:02:00 changed by rjollos

  • summary changed from Dynamicity of trac to Dynamicity of Trac (Show number of registered users).

10/31/12 08:07:04 changed by rjollos

  • owner changed from anybody to hasienda.
  • component changed from Request-a-Hack to AccountManagerPlugin.

I think we should provide the number of registered users in the AccountManagerPlugin via the UserStats macro.

(follow-up: ↓ 4 ) 10/31/12 21:31:46 changed by hasienda

  • keywords set to macro.

Yes, that fits in there indeed.

(in reply to: ↑ 3 ) 11/22/12 23:42:12 changed by hasienda

  • priority changed from highest to normal.

Replying to hasienda:

Yes, that fits in there indeed.

But the priority is not serious. This can easily be postponed behind the acct_mgr-0.4 release.

12/12/12 22:21:44 changed by hasienda

Hm, isn't it already there?

UserQuery(count)

will yield exactly the number of known users, see account-/user-related WikiMacros for everyone ("Requires USER_VIEW permission for output in any format other then 'count'."). Thoughts?

(follow-up: ↓ 7 ) 12/12/12 22:26:34 changed by rjollos

Yeah, that works well for me. I think we are covered on the macro side.

It might be nice to show the number of registered users somewhere on the /admin/accounts/users page, but that is a separate matter.

(in reply to: ↑ 6 ; follow-up: ↓ 8 ) 12/12/12 23:27:36 changed by hasienda

  • keywords changed from macro to admin panel.

Replying to rjollos:

Yeah, that works well for me. I think we are covered on the macro side.

Thanks for confirmation.

It might be nice to show the number of registered users somewhere on the /admin/accounts/users page, but that is a separate matter.

Oh, good catch , so why not read this request like that then ('main page' == 'user admin panel')? I'll do that.

(in reply to: ↑ 7 ) 12/12/12 23:32:51 changed by rjollos

Replying to hasienda:

Oh, good catch , so why not read this request like that then ('main page' == 'user admin panel')? I'll do that.

Yeah, the request is a bit ambiguous, but that makes sense. I looked at the user admin panel for a while, but the best place to locate the user count didn't jump out at me. Perhaps to the right of Manage User Accounts, like is done on the report page.

12/12/12 23:33:08 changed by rjollos

  • attachment ReportPage.png added.

12/30/12 23:29:48 changed by hasienda

(In [12496]) AccountManagerPlugin: Add number of accounts into user admin panel, refs #7426.

12/31/12 19:29:11 changed by rjollos

  • attachment th7426-r12500-1.patch added.

Patch against r12500 of the trunk.

12/31/12 19:29:51 changed by rjollos

From my work on t:#10743, I know of a different way to accomplish this, which could avoid adding the additional stylesheet: th7426-r12500-1.patch.

12/31/12 20:52:21 changed by rjollos

On second look, after the patch is applied the styling of the text is slightly different. I think the patch is an improvement though since the text is slightly larger, so I still favor applying the patch.

01/04/13 23:35:48 changed by hasienda

(In [12514]) AccountManagerPlugin: Obsolete additional CSS styles, refs #7426.

Changing to another .class allows to remove report.css, that has been added in [12496]. Thanks to Ryan J Ollos for proposing this simplification.

(follow-up: ↓ 14 ) 01/10/13 06:04:42 changed by rjollos

It appears I may have led you astray here because the trac-count class wasn't added until [t 11127], meaning the class isn't available in Trac < 1.0. I think the styling is nice though, and use of the trac-count class will provide consistent styling in Trac >= 1.0. Maybe we should copy the class to acct_mgr.css temporarily, until support for Trac < 1.0 is dropped (AccountManager 0.5 and later?).

(in reply to: ↑ 13 ; follow-up: ↓ 16 ) 01/13/13 21:53:51 changed by hasienda

Replying to rjollos:

It appears ... the class isn't available in Trac < 1.0. ... Maybe we should copy the class to acct_mgr.css temporarily, until support for Trac < 1.0 is dropped (AccountManager 0.5 and later?).

Good point. Let's do that.

Enough new stuff has been prepared for another "main" dot-release, so acct_mgr-0.5 will certainly get released before switching the plugin db backend code to Trac 1.0 API, consequently before 0.6dev.

01/13/13 22:19:39 changed by hasienda

(In [12532]) AccountManagerPlugin: Supply copy of recent Trac CSS style inside the plugin, refs #7426.

Done for compatibility with Trac < 1.0, even if its a very minor tweak.

(in reply to: ↑ 14 ) 01/13/13 23:20:24 changed by rjollos

Replying to hasienda:

Enough new stuff has been prepared for another "main" dot-release, so acct_mgr-0.5 will certainly get released before switching the plugin db backend code to Trac 1.0 API, consequently before 0.6dev.

Ah, right. I have the development plan straight in my mind, but keep mixing up the numbers when it comes time to type ;)

01/13/13 23:22:30 changed by rjollos

Oh, and just to avoid confusion down the road, we have everything straight in this ticket, but the code comment says Trac <= 1.0, whereas it should say Trac < 1.0.

01/25/13 22:21:00 changed by rjollos

See also t:#11027, which this ticket inspired.

01/25/13 23:36:54 changed by hasienda

(In [12571]) AccountManagerPlugin: Add descriptive tool-tip to 'Toggle account approval', refs #7426 and #8595.

A CSS style comment is now corrected as well.

Thanks to Ryan J Ollos for hints on these minor issues, nevertheless I care and I'm happy to receive code reviews for getting things straight.


Add/Change #7426 (Dynamicity of Trac (Show number of registered users))




Change Properties
Action