Ticket #7428 (new defect)

Opened 3 years ago

Last modified 11 months ago

[Patch] Ticket sidebar takes up half the screen width with Trac 0.12

Reported by: Dennis McRitchie <dmcr@Princeton.EDU> Assigned to: k0s
Priority: normal Component: TicketSidebarProviderPlugin
Severity: normal Keywords: misplacement CSS
Cc: Trac Release: 0.12

Description

As mentioned above, when the ticket sidebar is enabled, it takes up half the width of the screen instead of just a small portion. It does this whether there is anything to display in the sidebar area.

I have a couple of patches to: 1) Keep the ticket display centered and normal in size when there is no sidebar info to display; and 2) Simply move the ticket display to the left (but keep its normal size) when displaying sidebar info, whose size defaults to 20% of the content area.

Dennis

Attachments

ticketsidebar.py.patch (0.6 kB) - added by Dennis McRitchie <dmcr@Princeton.EDU> on 07/28/10 18:45:09.
Fix to only apply sidebar style sheet when there is sidebar content to display
ticket-sidebar.css.patch (0.5 kB) - added by Dennis McRitchie <dmcr@Princeton.EDU> on 07/28/10 18:47:11.
Sidebar style sheet to move ticket to the left, and default sidebar size to 20% of content area

Change History

07/28/10 18:45:09 changed by Dennis McRitchie <dmcr@Princeton.EDU>

  • attachment ticketsidebar.py.patch added.

Fix to only apply sidebar style sheet when there is sidebar content to display

07/28/10 18:47:11 changed by Dennis McRitchie <dmcr@Princeton.EDU>

  • attachment ticket-sidebar.css.patch added.

Sidebar style sheet to move ticket to the left, and default sidebar size to 20% of content area

08/20/10 09:40:33 changed by rjollos

  • summary changed from Ticket sidebar takes up half the screen width with Trac 0.12 to [Patch] Ticket sidebar takes up half the screen width with Trac 0.12.

06/27/12 23:10:54 changed by hasienda

(In [11697]) TicketSidebarProviderPlugin: Non-maintainer change applying old patch, refs #7428.

As proposed by Dennis McRitchie?, CSS definitions for this plugin should only be added if required (ticketsidebar.py.patch).

I couldn't detect a positive effect from this change alone, but no negative side-effects either, so this is more an excuse for a small code clean-up; tested with Trac 0.13-r10880.

06/27/12 23:13:13 changed by hasienda

(In [11698]) TicketSidebarProviderPlugin: Another non-maintainer commit to fix display issues, refs #7428.

CSS changes, that have a positive effect indeed, are applied here.

Thanks again to Dennis McRitchie?, who suggested these changes a long time ago; tested with trac 0.13dev-t:r10880 as well.

06/27/12 23:14:57 changed by hasienda

  • keywords set to misplacement CSS.

Comments welcome, if this ticket should be closed now.

Please see probably related issues, like #8785, as well.

Add/Change #7428 ([Patch] Ticket sidebar takes up half the screen width with Trac 0.12)




Change Properties
Action