Modify

Opened 4 years ago

Closed 4 years ago

#7641 closed defect (fixed)

Wiki page changes trigger a email announcement to all users that didn't set a preference

Reported by: tfotherby Owned by: doki_pen
Priority: normal Component: AnnouncerPlugin
Severity: minor Keywords:
Cc: Trac Release: 0.12

Description

I found that when a wiki page was changed, all trac users would be sent an announcement email about the change even if they didn't set anything in the "General Wiki Announcements" section of the preferences page. I would have expected only the users that were watching the page or have entered a wildcard (i.e. "*") should be sent a email?

For reference, I'm using trac 0.12 on centOS 5.5 and I installed trunk of Announcer on 27/Jul/10 via easy_install.

I was able to fix this issue by editing subscribers/wiki.py (sudo emacs /usr/lib/python2.4/site-packages/AnnouncerPlugin-0.12_p2.dev-py2.4.egg/announcer/subscribers/wiki.py)

from:

        def match(dist, value):
            for raw in value.split(' '):
                pat = urllib.unquote(raw).replace('*', '.*')
                if re.match(pat, event.target.name):
                    return True

to:

        def match(dist, value):
            if value == '':
                return False
            for raw in value.split(' '):
                pat = urllib.unquote(raw).replace('*', '.*')
                if re.match(pat, event.target.name):
                    return True

Attachments (0)

Change History (2)

comment:1 Changed 4 years ago by rjollos

I wonder if this is related to #6631.

comment:2 Changed 4 years ago by doki_pen

  • Resolution set to fixed
  • Status changed from new to closed

(In [8860]) Don't notify of any wiki change bug fix

Fixes #7641

Add Comment

Modify Ticket

Action
as closed The owner will remain doki_pen.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.