Modify

Opened 8 years ago

Closed 7 years ago

#787 closed defect (fixed)

Changes required to Screenshots Plugin when running under Windows

Reported by: kdahlhaus@… Owned by: Blackhex
Priority: normal Component: ScreenshotsPlugin
Severity: critical Keywords: trac
Cc: Trac Release: 0.10

Description

The plugin needs two minor changes to run out of the box under windows. The image content must be saved in binary format and os.mkdir throws an exception if the directory exsits. This might be a problem because delete leaves the numbered directory present. The following code changes to core.py around line 255 fix both problems and should not affect unix installations:

                # Store uploaded image.
                try:
                    if not os.path.exists(path):
                        os.mkdir(path)
                    out_file = open(large_filepath, "wb+") 

Is there any way to use the other image sizes or to show the image imbedded in a page instead of as a link? Thanks for a great plugin.

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by Blackhex

  • Status changed from new to assigned

I'll tak a look on that. Directories should be deleted exctept if some error breaks detete execution. Macro for direct image displaying is planned but I don't understand what do you mean by "way to use the other image sizes".

comment:2 Changed 8 years ago by kdahlhaus@…

The inline macro will be real nice.

It appears that the existing plugin uses ImagMajik to create different sizes of the uploaded image. I was wondering how those are used.

comment:3 Changed 8 years ago by Blackhex

Small image is used as preview in sides of list, medium image is prewiew in the center of list and big image is downloaded when you click on center image.

comment:4 Changed 7 years ago by Blackhex

  • Resolution set to fixed
  • Status changed from assigned to closed

Needed changes are applied since changeset 2542 and feature requests are planned for almost complete plugin rewrite.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.