Modify

Opened 4 years ago

Closed 4 years ago

#8021 closed defect (fixed)

[Patch] String formats should be `%(name)s` directive instead of `%s`

Reported by: jun66j5 Owned by: hasienda
Priority: normal Component: DynamicFieldsPlugin
Severity: normal Keywords: i18n
Cc: Trac Release: 0.12

Description

DynamicFieldsPlugin now uses %s in the messages catalog. It makes the translations difficult.
The formats should be %(name)s directive instead of %s.

directive-name.diff

Attachments (1)

directive-name.diff (3.4 KB) - added by jun66j5 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by jun66j5

comment:1 Changed 4 years ago by jun66j5

  • Summary changed from String formats should be `%(name)s` directive instead of `%s` to [Patch] String formats should be `%(name)s` directive instead of `%s`

comment:2 Changed 4 years ago by hasienda

  • Status changed from new to assigned

Looks saner, more understandable indeed. Thanks for the suggestion. You are a hurricane running through all the translations available by now, right? ;-) This is most appreciated.

comment:3 Changed 4 years ago by hasienda

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [9417]) DynamicFieldsPlugin: Change strings aka msgid's containing variable parts for web UI, closes #8021.

Replacements (%s) are rewritten with named variables like %(variable)s.
This helps a lot when translating without looking at the source code.
Thanks to Jun Omae for both, suggestion and providing actually better code.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from hasienda. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.