Modify

Opened 4 years ago

Closed 3 years ago

#8317 closed defect (fixed)

Patch containing bugfixes and enhancements for TracDiscussion 0.7

Reported by: dmcr@… Owned by: Blackhex
Priority: high Component: DiscussionPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

The DiscussionPlugin is a well-designed and very useful Trac plugin. In attempting to use it, I discovered a few bugs, which this patch fixes. I also found a need for a couple of usability enhancements, especially for projects with a large number of users.

All of these are described below:
Bug fixes:

  1. Display reply count in forum list as an integer rather than a FP number.
  2. In several places the code was checking for a ':'-separated subscriber list instead of a comma-separated list, thus leaving commas embedded as part of the email address, and failing to deliver the email in some cases.
  3. In the email notification code, self.config.get() was called instead of self.config.getlist(), resulting in trying to concatenate a string to a list. This failed, and resulted in a traceback.
  4. In the notification emails, in some cases, the list of moderators (when more than one) did not have any separator character(s) and therefore abutted one another. Added ', ' separator.
  5. Forum and Topic invitation emails could not be successfully parsed by the DiscussionPlugin email2trac code because the words 'forum' and 'topic' in the subject had no leading capital letter. Since all other notification emails had those words capitalized, these two notification email subjects were changed to conform. email2trac can now be used to reply to them.

Enhancements:

  1. The only way to add subscribers to forums and topics was to type them in manually. For Trac administrators whose projects have many users, and where they wish to subscribe many or all of their users, this was too time-consuming. So all moderator forms where subscribers can be added or edited now include both a select list of users as well as an input text box. These are concatenated internally as a single subscriber list.
  2. In the case of many users, the moderator select list and the new subscriber select list would get too long, and so the code has been changed to display no more than 6 names at a time. If there are more than 6 users, the list scrolls.
  3. For readability, the forum list and forum admin list display multiple moderators, and in the case of the forum admin list, multiple subscribers, as a comma-separated list. In some cases, the list was formerly space-separated.

I made minimum code changes to support all the above. Let me know if you have any questions or concerns. It's a great plugin, and I hope this will make it even more useful.

Dennis

Attachments (2)

discussionplugin-r9693.patch (25.9 KB) - added by dmcr@… 4 years ago.
Patch generated against DiscussionPlugin r9693
discussionplugin-r9693.patch.txt (25.9 KB) - added by dmcr@… 4 years ago.
Same patch file uploaded as a txt file.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by dmcr@…

Patch generated against DiscussionPlugin r9693

comment:1 Changed 4 years ago by dmcr@…

  • Summary changed from Patch containing bugfixes and enhacement for TracDiscussion 0.7 to Patch containing bugfixes and enhancements for TracDiscussion 0.7

Display of patch file attachment when I click on it shows many but not all of the changes in the patch file. Hopefully the file was uploaded correctly, but I can't verify it since I can't download it as other than an html file.

Changed 4 years ago by dmcr@…

Same patch file uploaded as a txt file.

comment:2 Changed 4 years ago by dmcr@…

The txt version of the (same) patch file shows all the lines without Trac attempting to run a (incorrect) patch operation on it. Looks like everything is there.

comment:3 Changed 3 years ago by Blackhex

  • Priority changed from normal to high
  • Status changed from new to assigned

I hope I'll take a look at this patch this weekend.

comment:4 Changed 3 years ago by Blackhex

  • Resolution set to fixed
  • Status changed from assigned to closed

Changeset more or less r9770 applies the patch and changeset r9786 improves it a bit.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Blackhex. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.