Changes between Initial Version and Version 2 of Ticket #8496


Ignore:
Timestamp:
Feb 13, 2011, 5:36:39 AM (13 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #8496

    • Property Summary changed from Big change to the child table functionality to [Patch] Big change to the child table functionality
    • Property Type changed from defect to enhancement
    • Property Severity changed from normal to minor

  • Ticket #8496 – Description

    initial v2  
    11I've made a major change to the way that childticketsplugin handles the table of children. It has a few drawbacks but the benefits are very significant. I think it needs someone else to look over it and come up with some ways to tidy it up. changes are as follows:
    2 * Removed the child table completely - The code was building a table in full when trac has the wiki engine to do this
    3 * Added a custom field called childreport
    4 * Added a ticket_created and ticket_changed handler to update the childreport of the parent ticket with a TicketQuery macro
     2 * Removed the child table completely - The code was building a table in full when trac has the wiki engine to do this
     3 * Added a custom field called childreport
     4 * Added a ticket_created and ticket_changed handler to update the childreport of the parent ticket with a !TicketQuery macro
    55
    66There are a few caveats.
    7 * If you change the macros, the parent does not get updated until you update a child.
    8 * The ticket_custom table is updated every time a ticket is changed, regardless of whether it needs to be
    9 * You cannot edit the childreport macro, it will always be overwritten when a child is modified
     7 * If you change the macros, the parent does not get updated until you update a child.
     8 * The ticket_custom table is updated every time a ticket is changed, regardless of whether it needs to be
     9 * You cannot edit the childreport macro, it will always be overwritten when a child is modified
    1010
    1111Benefits are pretty simple
    12 * Allows you to use wiki macros to define the table, i.e. grouping and data on rows
    13 * The wikitext field can also be used in custom queries
     12 * Allows you to use wiki macros to define the table, i.e. grouping and data on rows
     13 * The wikitext field can also be used in custom queries
    1414
    1515There are a few things I don't like. The code to handle the table_headers definition is a bit obscure. I've used a closure as it saves a bit of extra coding when i'm getting configuration directives but its not particularly readable. I've also not properly handled migrating from the child table to my version. Maybe we could add a config directive to tell it to use a field instead of rendering a table.
    1616
    17 Screenshot of the ticket screen is also attached along with a diff
     17Screenshot of the ticket screen is also attached along with a diff.
    1818
    1919Pete