Ticket #8513 (closed defect: invalid)

Opened 1 year ago

Last modified 4 months ago

Error in patch?

Reported by: bungybun@gmail.com Assigned to: cmc
Priority: normal Component: MultiSelectCustomFieldsPatch
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

In query.py shouldn't the change be 

+        modes['multi'] = [
+            {'name': _("contains"), 'value': "~"},
+            {'name': _("does not contain"), 'value': "!~"},

and not 

+        modes['multi'] = [
+            {'name': _("contains"), 'value': "|"},
+            {'name': _("does not contain"), 'value': "!"},

Attachments

Change History

(in reply to: ↑ description ) 04/07/11 21:41:17 changed by josh.applebaum@ziften.com

Replying to bungybun@gmail.com:

In query.py shouldn't the change be {{{ + modesmulti? = [ + {'name': _("contains"), 'value': "~"}, + {'name': _("does not contain"), 'value': "!~"}, }}} and not {{{ + modesmulti? = [ + {'name': _("contains"), 'value': "|"}, + {'name': _("does not contain"), 'value': "!"}, }}}

Have you gotten to test this out with the corrections? Also, how do you install this patch?

01/29/12 19:43:44 changed by cmc

  • status changed from new to closed.
  • resolution set to invalid.

I don't believe this addition is correct. Using a pipe indicates a different mode. Using a tilde would cause the '%' + value + '%' search to be used. Multiselect values should always end in a |, hence '%' + value + '|%' should be the search.

01/30/12 17:55:11 changed by cmc

Seems like this is a different request, but the same confusion found in #9731. Did you convert a normal select into a multi-select? If so, you'd need to append a pipe to all existing values. I'll add instructions on how to do this in the wiki.

01/31/12 01:34:40 changed by bungybun@gmail.com

It was for an old client and I no longer have the full code. It's unlikely that the patch failed to get through test with the client, but then that could be just luck (as in the config was established with a trailing pipe).

Add/Change #8513 (Error in patch?)




Change Properties
Action