Ticket #852 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

Small adaptational patch for python 2.3

Reported by: Shun-ichi Goto <shunichi.goto@gmail.com> Assigned to: coderanger
Priority: normal Component: TicketDeletePlugin
Severity: major Keywords:
Cc: Trac Release: 0.10

Description

Recent TicketDeletePlugin (r1415) is not work with python 2.3 due to lack of function sorted(). There's a patch.

Index: ticketdelete/web_ui.py
===================================================================
--- ticketdelete/web_ui.py      (revision 1450)
+++ ticketdelete/web_ui.py      (working copy)
@@ -3,6 +3,7 @@
 from trac import __version__ as TRAC_VERSION
 from trac.core import *
 from trac.ticket.model import Ticket
+from trac.util import sorted
 from trac.web.api import IRequestFilter
 from trac.web.chrome import ITemplateProvider, add_script, add_stylesheet
 from webadmin.web_ui import IAdminPageProvider

BTW, I got error entering this tikcet as user logged in to TracHack?

Traceback (most recent call last):
 File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 356,
in dispatch_request
   dispatcher.dispatch(req)
 File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 224,
in dispatch
   resp = chosen_handler.process_request(req)
 File "/usr/lib/python2.4/site-packages/trac/ticket/web_ui.py", line
127, in process_request
   self._do_create(req, db)
 File "/usr/lib/python2.4/site-packages/trac/ticket/web_ui.py", line
188, in _do_create
   self._validate_ticket(req, ticket)
 File "/usr/lib/python2.4/site-packages/trac/ticket/web_ui.py", line
66, in _validate_ticket
   for field, message in manipulator.validate_ticket(req, ticket):
 File "build/bdist.linux-i686/egg/tracspamfilter/adapters.py", line
39, in validate_ticket
 File "build/bdist.linux-i686/egg/tracspamfilter/api.py", line 78, in test
 File "build/bdist.linux-i686/egg/tracspamfilter/filters/regex.py",
line 39, in test
TypeError: expected string or buffer

Attachments

Change History

11/12/06 13:17:30 changed by coderanger

  • status changed from new to closed.
  • resolution set to fixed.

(In [1542]) Add compat for Python 2.3 (fixes #852).


Add/Change #852 (Small adaptational patch for python 2.3)




Change Properties
Action