Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#853 closed defect (fixed)

pdf conversion misses images if wiki not on standard port

Reported by: anonymous Owned by: athomas
Priority: normal Component: PageToPdfPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.9

Description (last modified by coderanger)

PDF conversion was missing images because my web server running Trac is not on a standard port. When I changed the line that is supposed to correct the image links from:

 page = re.sub('<img src="(?!\w+://', '<img src="%s://%s' % (req.scheme, req.server_name), page)


 page = re.sub('<img src="(?!\w+://', '<img src="%s://%s:%d' % (req.scheme, req.server_name, req.server_port), page)

Then it now works ok for me.

Thanks for a very useful plugin!

Attachments (0)

Change History (2)

comment:1 Changed 8 years ago by coderanger

  • Description modified (diff)

Fixing formatting

comment:2 Changed 8 years ago by coderanger

  • Resolution set to fixed
  • Status changed from new to closed

(In [1462]) Allow non-standard ports. Fixes #853.

Add Comment

Modify Ticket

as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from athomas. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.