Ticket #8680 (closed defect: fixed)

Opened 2 years ago

Last modified 10 months ago

setup should not require ExtractUrlPlugin

Reported by: walther@szgrf.bgr.de Assigned to: rjollos
Priority: normal Component: ServerSideRedirectPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

In setup.py the directive setup_requires = ['TracExtractUrl>=0.2.7030'] is set making egg building impossible on "non trac" machines.

Without it ./setup.py bdist_egg will run fine, also installation at the target system with installed TracExtractUrl.

So if there's no other reason I'm not aware of enforcing setup_requires, please drop it.

Attachments

Change History

08/04/12 02:41:10 changed by rjollos

  • owner changed from martin_s to rjollos.

Yeah, setup_requires doesn't seem to be needed. See setuptools documentation for more info. See also #6940.

We are planning to use this plugin on trac-hacks, so I hope it is okay with the author if I go ahead and fix the issue.

08/04/12 03:31:46 changed by rjollos

  • status changed from new to assigned.
  • Seems to be working well with 1.0dev, so I added the 1.0 tag to the project wiki page.
  • I had to change the import from from tracextracturl import extract_url to from tracextracturl.extracturl import extract_url. I think this could be avoided by modifying __init__.py in ExtractUrlPlugin.

08/04/12 03:37:38 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [11890]) Fixes #6940, #8680:

  • Removed setup_requires statement from setup.py. The listed package is only necessary for installation, not for running setuptools.
  • Modified import statement for extract_url since it was not importing correctly.

Tested with Trac 1.0dev-r11167.

Add/Change #8680 (setup should not require ExtractUrlPlugin)




Change Properties
Action