Modify

Opened 3 years ago

Closed 2 years ago

#8680 closed defect (fixed)

setup should not require ExtractUrlPlugin

Reported by: walther@… Owned by: rjollos
Priority: normal Component: ServerSideRedirectPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

In setup.py the directive setup_requires = ['TracExtractUrl>=0.2.7030'] is set making egg building impossible on "non trac" machines.

Without it ./setup.py bdist_egg will run fine, also installation at the target system with installed TracExtractUrl.

So if there's no other reason I'm not aware of enforcing setup_requires, please drop it.

Attachments (0)

Change History (3)

comment:1 Changed 2 years ago by rjollos

  • Owner changed from martin_s to rjollos

Yeah, setup_requires doesn't seem to be needed. See setuptools documentation for more info. See also #6940.

We are planning to use this plugin on trac-hacks, so I hope it is okay with the author if I go ahead and fix the issue.

comment:2 Changed 2 years ago by rjollos

  • Status changed from new to assigned
  • Seems to be working well with 1.0dev, so I added the 1.0 tag to the project wiki page.
  • I had to change the import from from tracextracturl import extract_url to from tracextracturl.extracturl import extract_url. I think this could be avoided by modifying __init__.py in ExtractUrlPlugin.

comment:3 Changed 2 years ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [11890]) Fixes #6940, #8680:

  • Removed setup_requires statement from setup.py. The listed package is only necessary for installation, not for running setuptools.
  • Modified import statement for extract_url since it was not importing correctly.


Tested with Trac 1.0dev-r11167.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.