Modify

Opened 4 years ago

Last modified 5 weeks ago

#8796 accepted defect

notifications also get sent to the smtp_always_cc address

Reported by: brecht Owned by: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: email notification private
Cc: rjollos Trac Release: 0.12

Description

I have the notification/smtp_always_cc option in trac.ini set to a mailing list address so that people can easily follow ticket changes. When AccountManager is sending notifications of user registration/deletion, these are also send to the smtp_always_cc address, in addition to the address(es) specified for AccountManager notifications. However, I don't want AccountManager to send to the smtp_always_cc address.

I have tried to adjust acct_mgr/notification.py to temporarily empty the smtp_always_cc option in the configuration, but this didn't seem to work. Probably I'm misunderstanding what is going on?

Attachments (1)

trac-accountmanager-fix-always_cc.patch (756 bytes) - added by arthur@… 3 years ago.
Patch to fix this issue. The implementation is based on the SingleUserNotification below.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by hasienda

  • Keywords email notification private added

This isn't the only notification-related issue. Please give me the chance to look at it after I've finished the currently prepared release.

Changed 3 years ago by arthur@…

Patch to fix this issue. The implementation is based on the SingleUserNotification below.

comment:2 Changed 3 years ago by rjollos

  • Cc rjollos added; anonymous removed

comment:3 Changed 19 months ago by mike_mp@…

  • Trac Release changed from 0.12 to 1.0

this workaround worked throughout trac 0.12 but now fails in trac 1.0.1. This issue makes it impossible for a trac to be sending ticket emails to a public list since all the username notifications go there too.

comment:4 follow-up: Changed 19 months ago by mike_mp@…

nevermind, it still works in 1.0, but you guys really need to commit this.

comment:5 in reply to: ↑ 4 Changed 19 months ago by hasienda

  • Trac Release changed from 1.0 to 0.12

Replying to mike_mp@zzzcomputing.com:

nevermind, it still works in 1.0, but you guys really need to commit this.

Point taken. But how about joining us? I could really use help with this high-profile plugin. Furthermore you could already assist by not changing ticket properties meant to help other developers spending their voluntary time more efficiently. Thanks for consideration and taking care.

comment:6 Changed 19 months ago by anonymous

whoops, didn't mean to change the release. The patch that's already attached works as is, you can commit it. Not sure what your testing procedure is.

comment:7 Changed 5 weeks ago by hasienda

In 14276:

AccountManagerPlugin: Don't notify users other than these in 'account_changes_notify_addresses' option, refs #8796.

Thanks to Arthur for proposing the change to fix this issue.

comment:8 Changed 5 weeks ago by hasienda

  • Status changed from new to accepted

Add Comment

Modify Ticket

Action
as accepted The owner will remain hasienda.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.