Modify

Opened 3 years ago

Closed 3 years ago

#8814 closed defect (fixed)

Generic word `for` is extracted, the term is difficult to translate in Japanese

Reported by: jun66j5 Owned by: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: i18n
Cc: Trac Release: 0.11

Description

Please apply the following patch that don't separate messages, if you can.

  • acct_mgr/templates/account_details.html

     
    1616      <div id="header"> 
    1717        <h2>Review User Account Details</h2> 
    1818        <py:choose> 
    19           <p py:when="name">for <b>${name}</b> (<em>${user}</em>)</p> 
    20           <p py:otherwise="">for <b>${user}</b></p> 
     19          <p py:when="name" i18n:msg="name,user">for <b>${name}</b> (<em>${user}</em>)</p> 
     20          <p py:otherwise="" i18n:msg="user">for <b>${user}</b></p> 
    2121        </py:choose> 
    2222      </div> 
    2323 

Attachments (0)

Change History (2)

comment:1 Changed 3 years ago by hasienda

  • Keywords i18n added
  • Status changed from new to assigned

Sure, I can and I certainly care for this type of issues, as I'm pushing i18n as well. Thanks for pointing this out.

Sometimes it's hard to spot such rough edges when I do a lot of coding without re-reading later. Your code review and testing is highly appreciated, as always.

comment:2 Changed 3 years ago by hasienda

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10242]) AccountManagerPlugin: (i18n) Patch account_details.html template, closes #8814.

Improved markup has been done similar to recommendation by Jun Omae, thanks!
Adds 1 msgid on catalog update. Hopefully I made the template more readable
too by shortening lines below the 80 chars limit.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.