Modify

Opened 4 years ago

Closed 4 years ago

#8843 closed defect (fixed)

[patch] XHTML invalid verify_email.html

Reported by: mitar Owned by: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: CSS
Cc: mmitar@… Trac Release: 0.11

Description

verify_email.html is XHTML invalid. It is necessary to apply this patch:

36,41c36,39
<         <div class="button central nav buttons">
<           <input type="submit" name="verify" py:attrs="button_state"
<                  value="${dgettext('acct_mgr', 'Verify')}" />
<           <input type="submit" name="resend" py:attrs="button_state"
<                  value="${dgettext('acct_mgr', 'Resend Email')}" />
<         </div>
---
>         <input type="submit" name="verify" py:attrs="button_state"
>                value="${dgettext('acct_mgr', 'Verify')}" />
>         <input type="submit" name="resend" py:attrs="button_state"
>                value="${dgettext('acct_mgr', 'Resend Email')}" />

So wrapping buttons in div. I used the same classes as they are used elsewhere in Trac for buttons.

Attachments (0)

Change History (4)

comment:1 Changed 4 years ago by hasienda

  • Keywords needinfo CSS added

Unsure. Would you please elaborate more on the subject.

It's not so much about to test, if you really know, but to teach me, so I'll understand and can spot similar cases with this plugin (or others) on my own. Does the change result in different representation with your browser, since (I guess) there is certainly some valid CSS definition for such a div section, right? Thanks for taking care.

comment:2 Changed 4 years ago by mitar

Yes. The whole point is to make XHTML layout the same as it is in Trac elsewhere. This means that. First templates should be XHTML valid (input elements by themselves are not XHTML valid, input elements are inline elements and need block elements around them, like div). Then this div should have some common Trac classes for buttons at the end of the form. I have added those in my patch above. This makes those buttons then easy to style. For example, in our customized theme we have all submit buttons styled so that they are aligned to the right of the page. This is possible with simple CSS for whole Trac (as all buttons have those classes). But for this plugin we had to fix templates a bit (those we are using and saw a problem).

For example, my patch for login.html in #6821 is also made according to what I believe is Trac way of layout. At least our CSS then styles it the same as everything else.

comment:3 Changed 4 years ago by hasienda

  • Keywords needinfo removed
  • Status changed from new to assigned

Thanks for the explanation. So this is certainly a valid claim.

I'll push this out right away, since you seemingly have already tested these modifications.

comment:4 Changed 4 years ago by hasienda

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10243]) AccountManagerPlugin: Fix invalid in verify_email.html, closed #8843.

Thanks to mitar for the patch and additional background information.

Add Comment

Modify Ticket

Action
as closed The owner will remain hasienda.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.