Modify

Opened 3 years ago

Closed 15 months ago

#8865 closed defect (wontfix)

Patch for Trac 0.12.2 release

Reported by: rlrj60 Owned by: akarzim
Priority: normal Component: TracHtmlNotificationPatch
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Attached here is a complete patch with a tarball that works great on Trac 0.12.2. The email notification looks exactly the same as the ticket view including description and comment fields. A new function being added to convert wiki description/comments to html.

Many thanks to Akazim for creating the original path.

Attachments (2)

html_notification_12_2.diff (24.4 KB) - added by rlrj60 3 years ago.
Complet patch based on Trac 0.12.2
html_notification_12_2.tar (50.0 KB) - added by rlrj60 3 years ago.
Files to replace those in Trac 0.12.2

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by rlrj60

Complet patch based on Trac 0.12.2

Changed 3 years ago by rlrj60

Files to replace those in Trac 0.12.2

comment:1 Changed 3 years ago by fzemanec@…

When I use this patch I get the following error on saving ticket changes:

Warning: The change has been saved, but an error occurred while sending notifications: __init__() takes exactly 3 arguments (2 given)

I have no knowledge about python, but I tried to dig in the code and the problem might be in trac/ticket/notification.py:

#rlrj60: to support html email notification
#   def __init__(self, env):
    def __init__(self, env, req):

I use Trac 0.12.2, python 2.7. If you need some more info, please let me know.

comment:2 follow-up: Changed 3 years ago by cobratec

Hi, i have the same problem in the init(), fzemanec@… any progress on your digging? I realyy need help on it.

comment:3 in reply to: ↑ 2 Changed 3 years ago by fzemanec@…

Replying to cobratec:

Hi, i have the same problem in the init(), fzemanec@… any progress on your digging? I realyy need help on it.

No progress. I just went back to plain-text notifications and waiting for someone to solve this.

comment:4 Changed 2 years ago by jpurohit

After using the patch, i.e. copying files to Trac 0.12.2 the settings are saved but email does not get sent. Did anyone find a solution for this?

Please update, Thanks

comment:5 Changed 15 months ago by rjollos

  • Resolution set to wontfix
  • Status changed from new to closed

It is suggested that you use the TracHtmlNotificationPlugin instead of the patch.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.