Modify

Opened 3 years ago

Closed 3 years ago

#8939 closed defect (fixed)

[patch] Fix for "mgr" not found error in http.py

Reported by: mwehr Owned by: hasienda
Priority: high Component: AccountManagerPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Hi,

Attached you will find a fix for a small bug in http.py

Index: http.py
===================================================================
--- http.py	(revision 332)
+++ http.py	(revision 333)
@@ -25,8 +25,8 @@
         doc = N_("URL of the HTTP authentication service"))
 
     def check_password(self, user, password):
-        acctmgr = HTTPPasswordMgrWithDefaultRealm()
-        acctmgr.add_password(None, self.auth_url, user, password)
+        mgr= HTTPPasswordMgrWithDefaultRealm()
+        mgr.add_password(None, self.auth_url, user, password)
         try:
             build_opener(HTTPBasicAuthHandler(mgr),
                          HTTPDigestAuthHandler(mgr)).open(self.auth_url)

regards

Mario

Attachments (0)

Change History (2)

comment:1 Changed 3 years ago by hasienda

(In [10374]) AccountManagerPlugin: Correct a left-over from [10339], refs #8925 and #8939.

This has been reported by Mario Wehr, thanks. Yet I preferred to fix the
attempted variable rename according to initial intention - the other way round.

comment:2 Changed 3 years ago by hasienda

  • Keywords patch removed
  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from Fix for "mgr" not found error in http.py to [patch] Fix for "mgr" not found error in http.py

(In [10393]) AccountManagerPlugin: Releasing version 0.3, pushing development to 0.4.

This new feature release finally propagates a number of solutions into an official release, after some time of testing with trunk, so explicitely closes #442, #816, #2966, #3989, #4160, #6821, #7111, #8534, #8549, #8663, #8813, #8892, #8925, #8936 and #8939.

Should have made this months ago, but felt so many pending issues were too bad for a new release. But it has been a tremendous ticket burndown since last year, so it's really worth considering an upgrade now. See fresh changelog for details.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.