Modify

Opened 3 years ago

Closed 3 years ago

#8986 closed enhancement (fixed)

Add SVN revision info to egg

Reported by: rjollos Owned by: ChrisNelson
Priority: normal Component: TracJsGanttPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Minor configuration management suggestion ...

Would you consider adding a setup.cfg file, like that shown here?

This makes it slightly easier to determine exactly the SVN revision number of an installed egg. This is helpful in case of an installation between version bumps (and as a second check in case a version bump is ever forgotten).

After adding that file to the DateFieldPlugin (and also bumping the version in setup.py) I get TracDateField-1.0.2_r10435-py2.6.egg rather than TracDateField-1.0.1-py2.6.egg.

The SVN revision also shows on the WebAdmin panel:

It is a very minor issue, but I don't know of any downsides. This seems to be a fairly common practice with Trac plugins.

Attachments (1)

SvnRevisionOnWebAdmin.png (15.5 KB) - added by rjollos 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by rjollos

comment:1 follow-up: Changed 3 years ago by ChrisNelson

That seems like a fine change. While it works fine for TH, we use git here so it seems I'd be carrying around a useless file for my local needs. And I wonder what my egg would look like here if I check out from git and build?

comment:2 in reply to: ↑ 1 ; follow-up: Changed 3 years ago by rjollos

Replying to ChrisNelson:

And I wonder what my egg would look like here if I check out from git and build?

I have not tried this, but I think it comes down to what setuptools supports. I'd be really interested to know however, since I've dropped this file into the directory of all the plugins I maintain, and many are using Git and Hg.

comment:3 in reply to: ↑ 2 Changed 3 years ago by ChrisNelson

Replying to rjollos:

Replying to ChrisNelson:

And I wonder what my egg would look like here if I check out from git and build?

I have not tried this, but I think it comes down to what setuptools supports. I'd be really interested to know however, since I've dropped this file into the directory of all the plugins I maintain, and many are using Git and Hg.

I guess I'd expect a tag_git_revision that works like tag_svn_revision.

comment:4 Changed 3 years ago by ChrisNelson

(In [10477]) Add setup.config. Refs #8986.

Names egg for SVN commit when built from an SVN checkout. Seems to be ignored for builds from git checkout.

comment:5 Changed 3 years ago by ChrisNelson

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Action
as closed The owner will remain ChrisNelson.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.