Ticket #9150 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

AttributeError happens with deleting a wiki page or a version of wiki page

Reported by: jun66j5 Assigned to: saigon
Priority: normal Component: WikiCreateTicketPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Traceback (most recent call last):
  File "build\bdist.win32\egg\trac\web\main.py", line 511, in _dispatch_request
    dispatcher.dispatch(req)
  File "build\bdist.win32\egg\trac\web\main.py", line 237, in dispatch
    resp = chosen_handler.process_request(req)
  File "build\bdist.win32\egg\trac\wiki\web_ui.py", line 148, in process_request
    self._do_delete(req, versioned_page)
  File "build\bdist.win32\egg\trac\wiki\web_ui.py", line 255, in _do_delete
    @self.env.with_transaction()
  File "build\bdist.win32\egg\trac\db\api.py", line 77, in transaction_wrapper
    fn(ldb)
  File "build\bdist.win32\egg\trac\wiki\web_ui.py", line 263, in do_delete
    page.delete(version, db)
  File "build\bdist.win32\egg\trac\wiki\model.py", line 114, in delete
    listener.wiki_page_deleted(self)
AttributeError: 'WikiCreateTicket' object has no attribute 'wiki_page_deleted'

I think WikiCreateTicket module should have the following methods.

Index: wikicreateticket/__init__.py
===================================================================
--- wikicreateticket/__init__.py	(revision 10640)
+++ wikicreateticket/__init__.py	(working copy)
@@ -20,6 +20,15 @@
     def wiki_page_changed(self, page, version, t, comment, author, ipnr):
         self.__parse_wiki_and_create_ticket(page, version)
 
+    def wiki_page_deleted(self, page):
+        pass
+
+    def wiki_page_version_deleted(self, page):
+        pass
+
+    def wiki_page_renamed(self, page, old_name): 
+        pass
+
     def __parse_wiki_and_create_ticket(self, page, version):
         page = WikiPage(self.env, page.name, version)
 

Attachments

Change History

09/06/11 11:11:30 changed by jun66j5

  • status changed from new to closed.
  • resolution set to fixed.

(In [10641]) Adds wiki_page_deleted, wiki_page_version_deleted and wiki_page_renamed. AttributeError happens when deleting a wiki page without these methods (fixed #9150).


Add/Change #9150 (AttributeError happens with deleting a wiki page or a version of wiki page)




Change Properties
Action