Ticket #9272 (closed enhancement: fixed)

Opened 2 years ago

Last modified 1 year ago

commit request: pragma to be able to set dir, scale etc.

Reported by: herby@mailbox.sk Assigned to: dthomas
Priority: normal Component: YumlPreprocessorMacro
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Here I include my changes to preprocessor macro. Urlencoding seems to be neede unlike the comment in actual version, diagrams with #comments did not work (no automatic urlenconding happened), so it is there explicitly.

It adds possibility to add line like: # pragma scruffy;dir:tb;scale:125 # into the diagram and its contents is taken into url.

Attachments

YumlPreprocessor.py (2.8 kB) - added by anonymous on 10/16/11 20:28:05.

Change History

10/16/11 20:16:48 changed by anonymous

I could not post the file... rejected as spam.

10/16/11 20:28:05 changed by anonymous

  • attachment YumlPreprocessor.py added.

10/16/11 20:29:28 changed by anonymous

I finally managed to upload the file after removing all http:// from comments...

10/17/11 22:33:43 changed by anonymous

After awhile of using it, a little quirk appeared with spaces shown as pluses, so quote_plus should in fact be only quote`. Otherwise it works nicely for me.

(follow-up: ↓ 5 ) 10/18/11 09:30:16 changed by dthomas

  • status changed from new to assigned.

Hi Herby, I have committed your code, changing all quote_plus calls to quote. Is this what you mean? Would you mind checking this out and testing it for me? Thank you!

(in reply to: ↑ 4 ) 10/18/11 11:14:45 changed by herby@mailbox.sk

Replying to dthomas:

Hi Herby, I have committed your code, changing all quote_plus calls to quote. Is this what you mean? Would you mind checking this out and testing it for me? Thank you!

Yes, this is what I meant (there should have been just two of them, both in yuml_url function).

Well, since it is identical to what I actually use (apart from http:// in comments, which I removed just ad-hoc to be able to post it in a copy I downloaded to my desktop, not in the original; and which do not change functionality) (I thought you would like to have as little changes as possible and commit it with those http:// parts re-added, so that diff is smaller, but ok, you took it verbatim :-) ), I am actually testing it by simply using it.

So far it works fine (even spaces are now spaces not pluses which was the case with quote_plus).

10/18/11 11:44:01 changed by dthomas

Great. I will run a small test myself and then resolve this as fixed. Thank you very much for posting the change!

02/06/12 08:05:24 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to fixed.

02/06/12 08:31:56 changed by rjollos

Btw, I closed this because it looked like someone just forgot to do that, but please correct if I'm wrong.

Add/Change #9272 (commit request: pragma to be able to set dir, scale etc.)




Change Properties
Action