Modify

Opened 3 years ago

Closed 18 months ago

#9498 closed defect (fixed)

[Patch] Released versions are visible for the day of release

Reported by: ak@… Owned by: rjollos
Priority: normal Component: ExtendedVersionPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Hi,

the test whether or not a version has been released actually only checks the date, not the datetime. This way a released version stays visible for the whole day and the label says "due in 33 sec" although it has been released 33sec ago.

Alex

Attachments (1)

release_versions_fix.patch (1.9 KB) - added by ak@… 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by ak@…

comment:1 Changed 3 years ago by ak@…

  • Summary changed from Released versions are visible for the day of release to [Patch] Released versions are visible for the day of release

comment:2 Changed 2 years ago by mestudd

ACK. This patch looks OK.

comment:3 Changed 2 years ago by rjollos

  • Owner changed from mestudd to rjollos
  • Status changed from new to assigned

One other related change I'd recommend is to make more extensive use of the trac.util.datefmt functions, which do a clean job of handling the user's timezone setting.

comment:4 Changed 18 months ago by rjollos

  • Status changed from assigned to new

comment:5 Changed 18 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

This issue was fixed in [13310]. The patch in release_versions_fix.patch was mostly correct, except that the timestamp is stored in utc time, so the comparisons need to be done relative to current utc time, not the current user time. Conversion to utc time before storing in database is done here; conversion from utc time to the user's time is done in the template here. format_datetime is a partial function that is passed to the template after populating the req.tz argument (the actual call is through the user_time helper function now, but that detail doesn't matter much).

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.