Modify

Opened 3 years ago

Closed 2 years ago

Last modified 22 months ago

#9555 closed defect (fixed)

System crash

Reported by: nike-17@… Owned by: rjollos
Priority: normal Component: DefaultCcPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

  1. Add Component - existed component name

Adding component whose name already existed will make system crash

  1. Remove selected component - no component selected

When there's no component selected then click "Remove selected component" will make system >crash
Fix: We need to check comp type
Traceback:

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/trac/web/api.py", line 378, in send_error
    'text/html')
  File "/usr/lib/python2.6/dist-packages/trac/web/chrome.py", line 745, in render_template
    stream |= self._filter_stream(req, method, filename, stream, data)
  File "/usr/lib/pymodules/python2.6/genshi/core.py", line 132, in __or__
    return Stream(_ensure(function(self)), serializer=self.serializer)
  File "/usr/lib/python2.6/dist-packages/trac/web/chrome.py", line 848, in inner
    data)
  File "/usr/local/lib/python2.6/dist-packages/Default_CC-0.1_r5293-py2.6.egg/defaultcc/admin.py", line 116, in filter_stream
    for comp in components:
TypeError: 'NoneType' object is not iterable

Attachments (0)

Change History (5)

comment:1 Changed 2 years ago by rjollos

  • Owner changed from jeangui to rjollos

comment:2 Changed 2 years ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

(In [11734]) Fixes #9555, #10156:

  • FIX: Traceback would occur when a system_message is raised, which could be due to component with same name already existing or 'Remove selected items' pressed with no items selected. Thanks to nike-17@… for the report.
  • FIX: Package was missing __init__.py file, which could result in a failure of the plugin to load.
  • FIX: Removed rollbacks on db upgrade, which fail in Trac 1.0dev and later since the db connection is read-only.

comment:3 Changed 2 years ago by rjollos

[11735] should have referenced this ticket. The post-commit hook here apparently doesn't like the colon after the keyword.

(In [11735]) Refs: #9555, #10156: Reverted unintended change in [11734].

comment:4 Changed 23 months ago by rjollos

(In [12022]) Refs #9555, #10156: Tagging version 0.2

comment:5 Changed 23 months ago by rjollos

(In [12023]) Refs #9555, #10156: Tagging version 0.1

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.