Switch to using jQuery UI 1.8.21

[rjollos]

Switch to using jQuery UI 1.8.21, which is currently used for the DateFieldPlugin and the KeywordSuggestPlugin.

[rjollos]

We'll have to use 1.8.16 since 1.7.3 doesn't have the Autocomplete widget.

[rjollos]

On my Trac 0.12.2 installation, I'm finding that the latest version of the KeywordSuggestPlugin (r11027) works fine with the latest version of the DateFieldPlugin (r11026), but I get an error when the AutocompleteUsersPlugin (r10974) is enabled. The error is found in the Error Console on FF8, and appears when editing the CC field. The keywords field just behaves as if the KeywordSuggestPlugin is disabled.

Error: $(this).data("autocomplete") is undefined
Source File: <Link removed>/ticket/640
Line: 82

The conflict appears to be because AutocompleteUsersPlugin is using an old version of ​jQuery autocomplete (1.0.2), while KeywordSuggestPlugin has been ported to using jQuery UI 1.8.16.

[rjollos]

#10097 closed as a duplicated.

[rjollos]

Replying to rjollos:

The conflict appears to be because AutocompleteUsersPlugin is using an old version of ​jQuery autocomplete

Which in fact has been deprecated in favor of jQuery UI 1.8 Autocomplete: ​http://docs.jquery.com/Plugins/Autocomplete.

[mitar]

Yes. jQuery autocomplete works nicely othewise, been using it in some other project.

[rjollos]

Latest stable is jQuery UI 1.8.21.

[agil]

Hi,

I have the same problem with Trac1.0.
Any sugestion or workaround to solve the problem?

Thanks!

[rjollos]

Not as far as I'm aware, but I'm in the process of upgrading my Trac instance to 1.0, and may get this plugin upgraded along the way.

[mwehr]

Hi,

I've migrated the plugin to work with the ui.autocomplete widget.
It is now compatible with TracKeywordSuggest,..... and other jQuery based plugins.
Feel free to test it ​download site
Tested on Trac 1.x

Mario

[rjollos]

Thanks, I will take a look and see about getting the changes applied to the repository.

[agil]

Thanks Mario!

Feel free to test it ​download site
Tested on Trac 1.x

Ooops, I got the error:

You don't have permission to access /wehr/ on this server.

I can't wait for the commit in the repo! ;-)

Thanks!

Albert

[mwehr]

Replying to mwehr:

Hi,

I've migrated the plugin to work with the ui.autocomplete widget.
It is now compatible with TracKeywordSuggest,..... and other jQuery based plugins.
Feel free to test it ​download site
Tested on Trac 1.x

Mario

Sorry there seems to be a problem with the http(s) stuff in my link :-)
Please use this ​download site

[agil]

Hi!

I've just tested and now it doesn't break the TracKeywordSuggest, great!

But:

• it puts the user's mail in the cc field instead of the username
  • or is it a configuration option?
• it only works for the first user you try to add
  • it seems to me that it is not parsing the cc field (names betweeb ",") and it's using the whole cc field as a single string to match a username, o something similar?

Thanks Mario!

Albert

[mwehr]

Hi Albert,

lol, I forget that it is also possible to add only the user name and trac searches for the mail addresses :-)
I will change that asap.
Up To now, if you choose a user for CC the mail addresses will get added with ";" as seperator. I'll change also ";" -> ","

Mario

[mwehr]

Hi Albert,

New version is online.

• Mail-addresses are separated with ",".
• Multiple mail receiver with auto-completion should work now.
• Mail selections now uses the user-name.
• Mail auto-completion items got a custom item layout.

Mario

[agil]

Hi Mario!

It seems that we are close!

Everything seems fine but when you add a second user to the cc field, the first one is just removed...

It hapens if you already have any number of users in the cc and you try to add a new one; all existing users are removed.

Thanks!

Albert

[anonymous]

Hi Albert,

I can add multiple users into the CC Field without problems. Also if I open a ticket with multiple users in the CC.
Tested on Firefox and IE.
Maybe you might need to clear your browser cache in case of old .js scripts?

Mario

[agil]

Replying to anonymous:

I can add multiple users into the CC Field without problems. Also if I open a ticket with multiple users in the CC.
Tested on Firefox and IE.
Maybe you might need to clear your browser cache in case of old .js scripts?

That's strange...
I re-deploied the trac installation, and tried with chrome and firefox.
And the problem persist...
Maybe is a problem with other plugins like KeywordsSuggest...?

Albert

[mwehr]

Albert,

Which version of Trac do you use?

[agil]

Replying to mwehr:

Which version of Trac do you use?

1.0

[agil]

Replying to agil:

Maybe is a problem with other plugins like KeywordsSuggest...?

I've done a simple test that maybe helps.
I note that it works different if you are also using the KeywordSuggestPlugin or not.

If I disable the KeywordSuggestPlugin, then the AutocompleteUsersPlugin seems that it's not working at all: no suggested users appear, the "waiting cursor/icon" doesn't apear...

But if I enable the KeywordSuggestPlugin, then the sugested users appear (also the sugested keywords), but the selected user is always removing the previous users in the cc field.

Does it help?

Thanks!

Albert

[rjollos]

I've started to take a look at the code by mwehr, but I probably won't get anything committed to the repository until at least this weekend. I'm attaching a diff of the changes.

[rjollos]

I've had no luck getting the patch to render properly after upload (known issue on t-h.o), so I've pasted it here: ​http://pastebin.com/RxweA4Lt.

[rjollos]

There is a lot of nearly identical code in the patch. Minor mutations on this function are common:

$.ajax({
    url: "../subjects",
    type: "GET",
    dataType: "text",
    data: 'q=' + extractLast( request.term ) ,
    success: function( data ) {
        response( $.map( data.split("\n"), formatItem ));
    }
});

Sometimes request.term is wrapped in a call to extractLast, and sometimes not. I haven't looked closely why that is. However, that difference aside, we could make a function with the url as the argument, and eliminate a lot of the code. Thoughts?