Modify

Opened 17 years ago

Closed 3 years ago

#972 closed enhancement (wontfix)

Hard coded start date in simile timeline

Reported by: tsvn@… Owned by:
Priority: high Component: SimileTimelinePlugin
Severity: major Keywords:
Cc: Trac Release: 0.10

Description

The date which is used to show the simile timeline is set twice in simile.js as this

date:           "Jul 28 2006 00:00:00 GMT",

If the two lines get removed the similie timeline would instead use the current date, which I guess is more useful for most people.

Arne

Attachments (0)

Change History (14)

comment:1 Changed 17 years ago by anonymous

Priority: normalhigh
Severity: normalmajor

Date time set to current date is useful.

comment:2 Changed 17 years ago by Markus Fuchs

Just replace them with

date: new Date().toGMTString(),

comment:3 in reply to:  2 Changed 17 years ago by anonymous

date: new Date().toGMTString(),

This is unneeded, since the original simile code already defaults to "today" if no other date is given.

Arne

comment:4 Changed 17 years ago by Markus Fuchs

Figured it out after having re-read the original ticket...

Actually, it would be nice to have the date by default set to what is entered in the View changes from field.

comment:5 Changed 17 years ago by David Roussel

... or the latest date in the returned dataset. I guess this would be easier to pass into the code than the actual value the user typed in.

comment:6 Changed 17 years ago by hg@…

please even add the year to the upper band - as I was wondering, why the timeline does not show anything... and 10% width is still enough for the upper band...

comment:7 in reply to:  6 ; Changed 17 years ago by anonymous

Not quite sure where I need to make the date change on this can someone give a filename

comment:8 in reply to:  7 Changed 16 years ago by anonymous

Replying to anonymous:

Not quite sure where I need to make the date change on this can someone give a filename

It worked for me to remove the two lines with hard-coded 2006 dates from each of the files stimeline/htdocs/js/simile.js and stimeline/templates/stimeline.cs. This always starts at today's date, rather than the actual date of the query, but that's not so bad as a quick fix; it's got to be better than July 2006.

Last edited 10 years ago by Ryan J Ollos (previous) (diff)

comment:9 Changed 14 years ago by anonymous

I have found that removing the DATE from my widget install will cause IE to fail to create the timeline. It does work correctly in FF. I will try date: new Date().toGMTString(), and see if that corrects my IE problem

comment:10 Changed 10 years ago by anonymous

:D

comment:11 Changed 10 years ago by Ryan J Ollos

Owner: changed from Noah Kantrowitz to Ryan J Ollos
Status: newaccepted

comment:12 Changed 9 years ago by Ryan J Ollos

Status: acceptednew

Refocusing.

comment:13 Changed 4 years ago by Ryan J Ollos

Owner: Ryan J Ollos deleted

comment:14 Changed 3 years ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

Obsolete and removed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.