Comment on implementation

[Ryan J Ollos]

I looked through the source for the plugin and did some testing, just generally curious of what features Trac is lacking that make the plugin necessary. I do this for lots of plugins, so this isn't meant to be critical of the implementation.

Looks like it could be implemented with the following features:

• ​#8069
• AdvancedTicketWorkflowPlugin's set_owner_to_field operation

Just using AdvancedTicketWorkflowPlugin eliminates about half the plugin code: t13268.diff​.

[ticket]
workflow = ConfigurableTicketWorkflow, TicketWorkflowOpOwnerField

[ticket-workflow]
reassign2 = new,assigned,accepted,reopened -> assigned
reassign2.operations = set_owner_to_field
reassign2.set_owner_to_field = project_usera

[Cauly]

This plugin is more a technical-validation for me. The two mian functions both uses a 'patch-style' method rather than normal plugin-style method in the implementation. This method is proved to be working, but It may cause unknown influence to other plugins.

Personally I do not recommand others to use this plugin in production. I wrote a notice on the wiki. If you think it's a serious problem, please feel free to remove this plugin.

[Ryan J Ollos]

I don't think it's a serious problem, but I think it's generally preferable to only have supported and recommended plugins on trac-hacks.org. I've been removing older plugins lately when the author is no longer around and the plugin is broken, there's a better option, or could cause problems if it's installed. I'll leave the final decision to you as to whether to remove this one.

[Cauly]

Got it.

Since I put a notice on the wiki and there's no replacement for the user-selection part, I choose not to delete for the time being. If you got know any plugins or trac upgraded to support this function, then it's ok to remove this plugin.

However, I seriously doubt that is there a way to implement this function in normal way, since I considered a long time and finally have no choice but to use this ungraceful implemetation.