ticket summary type release owner status created modified _description _reporter
4683 Start code review from source browser enhancement 0.11 new 2009-02-23T11:06:53+01:00 2017-05-27T10:04:43+02:00 If I review a working ticket I start on the files depending to this ticket. If I found some strange code I would like to start/create a code review from this (source browser) view. It's not so efficient to create the code review on a separate page navigating to the file(s) again. weltweitehrlich
12782 Reviewers group can not contains sub groups defect 1.0 Cinc-th assigned 2016-05-22T22:26:28+02:00 2016-05-26T09:53:16+02:00 "I set up the '!developer' group gathering few other groups and a testing profile, this group has been granted `CODE_REVIEW_DEV` in order to became my reviewers group.[[BR]]
When I create a new code review, I can only choose my testing profile as it seems it didn't go deep." ntmlod
2899 Review sections not just lines enhancement 0.10 new 2008-04-11T17:51:36+02:00 2017-05-27T10:04:43+02:00 "This plugin is really great for reviewing a few lines here and there but for anything larger it doesn't work so well.
* It would be nice to be able to create comments on the whole review and not just per line.
* It would also be good to be able to see all sections of the review at the same time since they are usually related." simongdkelly@…
13583 Refactor component PeerReviewView enhancement Cinc-th assigned 2019-08-11T13:45:23+02:00 2019-08-11T20:49:09+02:00 "The code esp. in {{{process_request()}}} is so convoluted, it's difficult to see what's happening there. Testing is hard or impossible, too.
While at it change the template names, see #10731." Cinc-th
10782 Move data models to model.py task Cinc-th assigned 2013-01-10T07:36:24+01:00 2019-08-10T08:11:10+02:00 To conform to common Trac code conventions, the data model should be contained in `model.py`: `ReviewFilesStruct.py`, `ReviewerStruct.py`, `ReviewCommentStruct.py` and `CodeReviewStruct.py`. Ryan J Ollos
6612 Make it work with Bazaar enhancement 0.11 new 2010-02-11T17:35:46+01:00 2017-05-27T10:04:43+02:00 As launchpad supports code review with bazaar, such support is lacking for Trac ... Vincent
2040 Make comments editable enhancement 0.11 new 2007-09-12T16:57:50+02:00 2017-05-27T10:04:43+02:00 "It would be nice if users could edit or even delete their own comments.[[BR]]
I think there should be a option in trac.ini or in the CodeReview-Manager where you could activate or deactivate this function." c.posluschni@…
4553 issues with peerreview and trac (with fastcgi) defect 0.11 new 2009-01-31T09:49:36+01:00 2017-05-27T10:04:43+02:00 "Hey,
I've several issues with trac running via fastcgi and Peerreview:
The mainpage works without any issues, but if I then try to go so a subpage (e.g Create a Code Review) the link doesn't point to : http://www.domain.net/peerReviewNew but to: http://www.domain.net/www.domain.net/peerReviewNew which will of course fail.
To see this on your own please have a look on our site: www.midnight-commander.org (you'll only see this option if you are a registered user I guess).
Please help me to get this running to make code review easier for us.
Thanks in advance
" winnie@…
12936 "IntegrityError: null value in column ""data_id"" violates not-null constraint" defect 1.0 Cinc-th new 2016-11-08T18:25:11+01:00 2016-11-11T19:25:08+01:00 "Just after the installation of python-docx 0.8.6, the entire Trac instance felt down:
{{{
File ""/usr/lib/python2.7/site-packages/trac/web/main.py"", line 497, in _dispatch_request
dispatcher.dispatch(req)
File ""/usr/lib/python2.7/site-packages/trac/web/main.py"", line 169, in dispatch
for handler in self.handlers:
File ""/usr/lib/python2.7/site-packages/trac/core.py"", line 78, in extensions
components = [component.compmgr[cls] for cls in classes]
File ""/usr/lib/python2.7/site-packages/trac/core.py"", line 199, in __getitem__
component = cls(self)
File ""/usr/lib/python2.7/site-packages/trac/core.py"", line 138, in __call__
self.__init__()
File ""build/bdist.linux-x86_64/egg/codereview/peerreview_docx.py"", line 131, in __init__
rdm.insert()
File ""build/bdist.linux-x86_64/egg/codereview/tracgenericclass/model.py"", line 462, in insert
@self.env.with_transaction(db)
File ""/usr/lib/python2.7/site-packages/trac/db/api.py"", line 97, in transaction_wrapper
fn(ldb)
File ""build/bdist.linux-x86_64/egg/codereview/tracgenericclass/model.py"", line 500, in do_insert
[values[name] for name in std_fields])
File ""/usr/lib/python2.7/site-packages/trac/db/util.py"", line 65, in execute
return self.cursor.execute(sql_escape_percent(sql), args)
}}}
For information as it seems related to DB operations, ours is a Postgres one.
* PeerReview 3.0 (r15579)
* TracGenericClass 1.1.6" ntmlod
14006 Improve CSS and page design enhancement 1.2 Cinc-th new 2021-04-22T08:58:45+02:00 2021-04-30T10:21:05+02:00 "The current presentation is space wasting and overloaded.
Try to improve by rearranging items and tweaking CSS styles. Folding page sections may also be considered." Cinc-th
12923 Fix for uppercase issue with Menus plugin enhancement 1.0 Cinc-th new 2016-10-31T14:31:20+01:00 2016-11-20T12:08:16+01:00 "Not a clever one but it was essential for us to be able to move the navigation item.
{{{#!diff
--- codereview/peerReviewMain.py (révision 15905)
+++ codereview/peerReviewMain.py (copie de travail)
@@ -85,12 +85,12 @@
# INavigationContributor methods
def get_active_navigation_item(self, req):
- return 'peerReviewMain'
+ return 'peerreviewmain'
def get_navigation_items(self, req):
if 'CODE_REVIEW_DEV' in req.perm:
- yield ('mainnav', 'peerReviewMain',
- Markup('Peer Review') % req.href.peerReviewMain())
+ yield ('mainnav', 'peerreviewmain',
+ Markup('Peer Review') % req.href.peerreviewmain())
# IPermissionRequestor methods
@@ -128,7 +128,7 @@
def match_request(self, req):
- return req.path_info == '/peerReviewMain' or req.path_info == ""/preview_render""
+ return req.path_info == '/peerreviewmain' or req.path_info == ""/preview_render""
def process_request(self, req):
req.perm.require('CODE_REVIEW_DEV')
}}}" ntmlod
4357 Enable CODE_REVIEW_DEV and CODE_REVIEW_MGR permmision by peerReviewInit enhancement 0.11 new 2009-01-02T05:20:32+01:00 2017-05-27T10:04:43+02:00 "Hi,
I wrote Trac Lightning which is Trac distribution with Subversion, Hudson, etc. It's purpose is not only for software developer. In software development peerreview plugin is very valuable but it's unnecessary for other perpose.
So, I would like to disable/enable peerreview menu by peerReviewMain plugin. However CODE_REVIEW_DEV and CODE_REVIEW_MGR permission are broken while peerReviewMain was disabled.
So, I would like to move IRequestorPermission interface in peerReviewMain to peerReviewInit. I attached the patch is included Trac Lightning.
I you took my patch, our codebase is same and I'm happy.
regards,
--
Takashi Okamoto
" okamototk
3214 Email notifications when code reviews include you enhancement 0.10 new 2008-06-18T21:43:50+02:00 2017-05-27T10:04:43+02:00 "Right now trac gives me notifications for ticket changes, but not for new code reviews that I am required to look at. This may already be available, but there is almost no documentation to look through.
Thanks in advance!
John" john.j.brennan@…
2850 Discussion and comments enhancement 0.12 new 2008-04-03T22:51:20+02:00 2017-05-27T10:04:43+02:00 "Please use that ticket for discussion and comments only. Any feature requests should be raised as a separate tickets (enhancements). '''DO NOT CLOSE''', please.
----
All the comments that were added to the main wiki page have been moved in here just for visibility. " Sebastian Marek
14004 Default templates for docx export are not available defect 1.2 Cinc-th new 2021-04-20T14:20:04+02:00 2021-04-20T14:20:04+02:00 "There are no default templates for {{{docx}}} export of reviews available.
The admin page is telling the user otherwise." Cinc-th
2134 Choose users not in the list but with a simple form enhancement 0.11 new 2007-10-30T21:50:56+01:00 2017-05-27T10:04:43+02:00 "If you using LDAP authentification, users aren't stored in sqlite DB. So, the dropdown list is always empty. A simple workaround is to choose manually users with simple form, like original assign to field in new ticket form.
Nevermind, great job !" sdouche
3393 Cannot add user when use LDAP authentication with apache defect 0.11 new 2008-07-15T12:50:57+02:00 2017-05-27T10:04:43+02:00 " I'm using Apache to authenticate user with my LDAP server, but when I want to create a code review, I can't select the user from the combo box as reviewer.
It should support a way for me to enter free text in.
" tinh.truong@…
228 Amazing for code, can it be extended to wiki pages? enhancement 0.11 new 2006-03-18T18:58:25+01:00 2018-04-14T20:46:19+02:00 We like to link all our code to wiki pages in trac that contain the specifications - this tool would be very useful for the review of those too. paudley@…
14007 Allow code reviews on changeset page enhancement 1.0 Cinc-th assigned 2021-04-28T10:38:48+02:00 2021-05-11T13:52:28+02:00 "It's already possible to perform code reviews on changesets. The user creates a review on the changeset page and all the files are attached to a new review. The review is then done using the review pages provided by the plugin.
=== Changes
It would be nice if reviews could be performed directly on the changeset page.
Things to consider:
* Reuse the current features. Don't create a second detached review mechanism
* Added files are only shown as links on the changeset page, no diff view at all.
* Allow several reviews?
* Allow commenting on source browser pages?
* If so, how to deal with ""normal"" reviews created by the user using the ''Create Review'' pages?
=== Implementation
* Let the user create a review on the changeset page (already implemented)
* If there is an associated review for a changeset provide {{{addComment()}}} links for each line in the source browser.
* Automatically load any available comments on page load" Cinc-th
1643 add option to manage reviews from trac-admin enhancement 0.10 new 2007-06-09T18:59:04+02:00 2017-05-27T10:04:43+02:00 I'd like be able to delete certain code reviews from using, say, trac-admin, or some other way (via the Web?) haizaar@…
5395 [Patch] Add keywords to reviews enhancement 0.12 Cinc-th assigned 2009-06-18T19:34:57+02:00 2016-02-01T17:04:05+01:00 "Our team needs to track reviews by Feature-IDs. To accomplish that it would be very nice to have a ""Feature ID"" field per review.
But I understand that other people do not need this, or name it differently. So I just want to ask for a ""keywords"" field where everybody can use it after its own desire." filthycoder
14003 ''Show comments inline'' doesn't work for newly created comments defect 1.2 Cinc-th new 2021-04-20T09:43:17+02:00 2021-04-20T09:43:17+02:00 "When starting a review comments are shown in pop-up dialogs. After creating a comment the red pin marks the line of the comment. Clocking the pin opens the comment.
When selecting {{{Show comments inline}}} nothing happens. After reloading the page clicking the checkbox shows the new comment inline as expected." Cinc-th