ticket	summary	type	release	owner	status	created	modified	_description	_reporter
7403	[Patch] Minor enhancements for the codereviewplugin	enhancement	0.11	Jörg Viola	new	2010-07-22T07:39:21+02:00	2010-08-18T21:34:35+02:00	"I've made some minor changes for this plugin, please review:
 1. the changeset author should not be the code reviewer
 1. the reviewer showed at changeset page is not correct in the original version
 1. when there's no comment, the ""Passed"" and ""Comment"" string will be overlapped

Please see attached patch."	bhduan@…
7180	Review is not saved	defect	0.11	Jörg Viola	new	2010-05-29T19:43:55+02:00	2010-05-29T19:43:55+02:00	"After clicking ""review"" on a changeset, I see the changeset again with the content I entered. No sign if it got saved or anything.

If entering the changeset everything I entered is gone, rendering the plugin useless."	dino@…
6500	Resubmit for Review button throws Unicode coersion error	defect	0.10	Jörg Viola	new	2010-01-27T11:54:13+01:00	2010-01-27T11:54:13+01:00	"I'm trialling this hack with a small team and have come across a problem.  I have assigned myself {{{CODE_REVIEW_DEV}}} and {{{CODE_REVIEW_MGR}}} permissions, and my devs {{{CODE_REVIEW_DEV}}} permission.  I created a new code review on {{{r4097}}} of our repo, added a bunch of files that were newly added to the branch in that revision.  I then went ahead with the review, adding comments to several files and ultimately rejecting the review.  So far so good.

My developer then re-worked the files in question and committed the changes to the branch.  At this point I'm not quite sure how it's supposed to work, but my assumption is that I click the ''Resubmit for Review'' button, select a new revision for the review and go through the process again.  Unfortunately when I click the ''Resubmit for Review'' button I get the following error:

{{{
Traceback (most recent call last):
  File ""C:\Python24\lib\site-packages\trac\web\main.py"", line 387, in dispatch_request
    dispatcher.dispatch(req)
  File ""C:\Python24\lib\site-packages\trac\web\main.py"", line 237, in dispatch
    resp = chosen_handler.process_request(req)
  File ""build\bdist.win32\egg\codereview\peerReviewNew.py"", line 90, in process_request
TypeError: coercing to Unicode: need string or buffer, int found
}}}

I haven't attempted to investigate in the code.

We're using Trac 0.10.3.1 on Python 2.4 with a SQLite backend on Windows 2003."	james.tait@…
7331	this does not work with trac0.12	defect	0.12	Jörg Viola	new	2010-07-05T05:32:14+02:00	2010-07-05T05:32:14+02:00	when it's going to support 0.12, 0.11 does not work either, for templates has changed to gensi	anonymous