ticket	summary	type	release	owner	status	created	modified	_description	_reporter
7349	Plugin does not filter private comments in notification email	defect	0.12	Michael Henke	new	2010-07-08T10:52:09+02:00	2020-05-06T01:28:12+02:00	"The Plugin only filters the ticket page to remove private comments.
Email notification is not filtered.

I tried MailToTracPlugin which promises to make it possible to filter the notifications but it did not work.
The only way I know to enable an email filter is via a change at the trac core.
 
The attached trac.ticket.notification checks the status of a comment before it sets the email text. If the comment is private it replaces the comment text with a neutral 'The comment is private'. The special permission is not checked so users with this permission have to click at the link at the lower end of the email.

I'd like to get rid of the core changes so if there is anybody who knows how to filter notifications via plugin -> please help me :)"	Michael Henke
13776	Fails with 1.4.1	defect	1.4	Ryan J Ollos	new	2020-04-06T22:39:00+02:00	2020-07-28T12:53:03+02:00	"Dear Colleagues,
When enabled under 1.4,
{{{
Trac Error

TracError: Unable to check for upgrade of privatecomments.privatecomments.PrivateComments: TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)
trac-admin upgrade also fails.
trac.log:
 Trac[env] ERROR: Component <Component privatecomments.privatecomments.PrivateComments> failed with
Traceback (most recent call last):
  File ""/usr/local/lib/python2.7/dist-packages/trac/env.py"", line 387, in component_guard
    yield
  File ""/usr/local/lib/python2.7/dist-packages/trac/env.py"", line 750, in needs_upgrade
    if participant.environment_needs_upgrade():
TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)
2020-04-06 22:34:35,628 Trac[env] ERROR: Exception caught while checking for upgrade: TracError: Unable to check for upgrade of privatecomments.privatecomments.PrivateComments: TypeError: environment_needs_upgrade() takes exactly 2 arguments (1 given)
}}}"	laszlo.elbert@…