#11252 closed defect (fixed)
Cannot hide "hours" main nav
| Reported by: | Jared | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Component: | TracHoursPlugin |
| Severity: | normal | Keywords: | |
| Cc: | Trac Release: | 1.0 |
Description
This is a great plugin. Currently in trac 1.0.1 I am unable to hide the "hours" tab from users who DO NOT have the TICKET_ADD_HOURS permissions. Can you please advise on an effective method to do so?
Attachments (0)
Change History (15)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
If I were that technically inclined I would, but unfortunately I am not. Please however do let me know how I may be able to assist.
comment:5 Changed 11 years ago by
I think what we really need is a TICKET_VIEW_HOURS permission. If the user doesn't have TICKET_ADD_HOURS, they may still want the ability to view hours. I'll have to take a closer look though.
comment:6 Changed 11 years ago by
I was under the impression that is how this plugin is currently developed to work, if a user does not have TICKET_ADD_HOURS they are unable to see the "Hours" tab in the main nav AND add hours / change hours for any ticket.
comment:7 Changed 11 years ago by
Thanks for the feedback. I'm planning to finish up this ticket on the coming Saturday. I'll let you know if anything changes with regard to that.
comment:9 Changed 11 years ago by
I didn't get to this last weekend, though it's on my list for the coming weekend (along with #11275).
comment:13 Changed 11 years ago by
I didn't have much time to spend on this, which partially accounts for the sloppiness of [13356-13358]. The changes could benefit from additional testing. Please report back if you can.
comment:14 Changed 11 years ago by
| Resolution: | → worksforme |
|---|---|
| Status: | assigned → closed |
The changes work perfectly. Thank you for implementing the new permission set and being so responsive to the feedback.
comment:15 Changed 11 years ago by
| Resolution: | worksforme → fixed |
|---|
It looks like we aren't doing the necessary permission checks in the INavigationContributor implementation. It will be straightforward to fix. Could I interest you in generating a patch?