Modify ↓

Opened 10 years ago

Closed 7 years ago

Last modified 7 years ago

#11545 closed defect (fixed)

Cannot log out when deleting user with Trac 1.0.2dev r12379 or later

Reported by: Jun Omae Owned by: Ryan J Ollos
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: logout
Cc: Trac Release: 1.0

Description

After ​t:r12379, Logout of Trac, LoginModule._do_logout, requires POST request. However, AccountManagerPlugin redirects to /logout when deleting user at source:accountmanagerplugin/trunk/acct_mgr/web_ui.py@13290:246#L226​. Therefore, the user cannot be logged out after ​t:r12379.

Attachments (0)

Change History (6)

comment:1 Changed 10 years ago by Steffen Hoffmann

I saw this coming after getting cc-ed to the aforementioned Trac ticket.

As I see it, AcctMgr

  • needs to detect whether or not POST is required
  • in case POST is required, it must compose and issue a fake POST request instead of a redirect

Please correct, if I'm wrong.

comment:2 Changed 7 years ago by Ryan J Ollos

Owner: Steffen Hoffmann deleted

comment:3 Changed 7 years ago by anonymous

as a workaround, install TracPermRedirect (https://trac-hacks.org/svn/permredirectplugin/trunk/), this will fix the post issue

comment:4 Changed 7 years ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: new → accepted

The auth cookie is deleted when deleting a user so I don't even see the need to redirect to LoginModule._logout. I think we can just redirect to /login when deleting an account.

Version 0, edited 7 years ago by Ryan J Ollos (next)

comment:5 Changed 7 years ago by Ryan J Ollos

In 16870:

TracAccountManager 0.5dev: Redirect to /login after deleting an account

Refs #11545.

comment:6 Changed 7 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.