Changes between Version 2 and Version 3 of Ticket #11664, comment 9


Ignore:
Timestamp:
May 28, 2015, 5:13:41 PM (9 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11664, comment 9

    v2 v3  
    1 If I change to the `to_utimestamp(datetime.now(utc))` mentioned above, what do I change the pretty printing to?
    2 https://trac-hacks.org/browser/codereviewerplugin/0.12/coderev/model.py?rev=13697&marks=200,201,202,203#L200
     1If I change to the `to_utimestamp(datetime.now(utc))` mentioned above, what do I change the pretty printing to [browser:/codereviewerplugin/0.12/coderev/model.py@13697:200-203#L200]?
     2
    33Do I just need to change 203 to `pretty_when += ' (%s ago)' % pretty_timedelta(from_utimestamp(when))` and the previous three lines are OK as is?
    44
    55[Edit:] Or, actually, shouldn't need to change even 203? I can't tell because I'm not sure which ones are supposed to be in localtime and which in UTC.
    6 Also the other location, https://trac-hacks.org/browser/codereviewerplugin/0.12/coderev/util/reviewer.py?marks=94#L94 not clear if needs to be changed.
     6Also the other location, [browser:/codereviewerplugin/0.12/coderev/util/reviewer.py@13697:94#L94] not clear if needs to be changed.