Doubleclick on checkbox labels doesn't work on filters added through the OR menu

[Ryan J Ollos]

Thank you for the nice plugin. I found it very useful and I'm working on adding the features to the Trac core in ​trac:#11417. Please feel free to comment on that ticket. Most likely the QueryUiAssistPlugin won't be needed by Trac 1.2. One fewer plugin is always nice :)

The issue I encountered is that the double-click doesn't function on the label of a checkbox when a filter is added using the OR selector.

I set off to fix this, and ended up making a few other changes as well:

• Fixed implicitly declared variables
• Optimized some jQuery selectors by limiting the scope of the search
• Some PEP-0008 changes in the Python code.
• Use ​prop rather than attr since Trac 1.0 uses jQuery 1.8.

The patch is attached. I hope it doesn't seem like I'm picking at your code. I learned far more from studying it than I'm contributing with the minor list of issues above :)

[Jun Omae]

I think it would be simple and easy to use .on() method to handle delegated events rather than setTimeout(). See t12062-delegated-events.diff​.

[matobaa]

In 14387:

closes #12062

[Ryan J Ollos]

There's a minor regression in [14387]. Double-click on a checkbox still selects the checkbox and clears all the neighbours, but double-click on the label of a checkbox no longer clear all the neighbours.

queryuiassistplugin/1.0/uiassist/htdocs/js/enabler.js

@@ -21 +21 @@
   function binder() {
     var $filters = $("#filters");
     $filters.on('dblclick', 'label', flip);
-    $filters.on('dblclick', ':checkbox', selectone);
+    $filters.on('dblclick', ':checkbox, :checkbox + label', selectone);
   }
 
   $(document).ready(function() { binder() })

[matobaa]

thanks! I'll update soon...

[matobaa]

In 14391:

QueryUiAssistPlugin: closes #12062

[Ryan J Ollos]

One more change. Although it appears to be harmless, the flip function is executed when double-clicking on a checkbox or its label. The following fixes the issue:

queryuiassistplugin/1.0/uiassist/htdocs/js/enabler.js

@@ -20 +20 @@
   // bind "flip" above to labels in page.
   function binder() {
     var $filters = $("#filters");
-    $filters.on('dblclick', 'label', flip);
-    $filters.on('dblclick', ':checkbox, :checkbox + label', selectone);
+    $filters.on('dblclick', 'th label', flip);
+    $filters.on('dblclick', 'td :checkbox, td :checkbox + label', selectone);
   }
 
   $(document).ready(function() { binder() })

The addition of the th selector is what fixes the issue. The td selectors were just added for code clarity.

[Ryan J Ollos]

New ticket for integrating this plugin to the Trac core is ​trac:#11970.

[Ryan J Ollos]

I added a notice in QueryUiAssistPlugin@9. Please let us know if you have any suggestions about the changes in ​trac:#11970. My aim is to make this plugin no longer necessary by Trac 1.2, by having equivalent functionality in Trac.

[matobaa]

Glad to hear that the function is now in Trac core, thank you!

[Ryan J Ollos]

Is it okay to commit the change in comment:7?

[matobaa]

yes!

[Ryan J Ollos]

Thanks! Fixed in [14862].

[Ryan J Ollos]

Changes in ​trac:#11970 have finally been committed (​changeset:14225). ​Thanks Matobaa!