Changes between Initial Version and Version 1 of Ticket #12696


Ignore:
Timestamp:
Mar 8, 2016, 6:23:51 AM (8 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12696 – Description

    initial v1  
    1 The issue I experienced is that none of the plugin tables were being migrated for an installation. I discovered that the plugins had been installed in the `plugins` directory and were not explicitly enabled in trac.ini, instead were implicitly enabled (TracPlugins#Plugindiscovery). The tables were migrated after explicitly enabling the plugin components. This is an in-place migration.
     1The issue I experienced is that none of the plugin tables were being migrated for an installation. I discovered that the plugins had been installed in the `plugins` directory and were not explicitly enabled in trac.ini, instead were implicitly enabled (TracPlugins#Plugindiscovery).
    22
    33It looks like plugins must be explicitly enabled for the tables to be migrated: [browser:/tracmigrateplugin/0.12/tracmigrate/admin.py@14655:113,117-118#L97].
    44
    5 Maybe not code change is needed though, rather just a note added to the documentation.
     5The tables were migrated after explicitly enabling the plugin components. This is an in-place migration.
    66
    7 Even if we only document the caveat for the plugin, when adding the feature to Trac (trac:#12299) maybe we should consider a more robust approach. I never really like that plugins are implicitly enabled when added to the `plugins` directory. Maybe that behavior should be changed for Trac 1.2? I hesitate to suggest that a bit though, because unless we can automatically populate the components section on upgrade, then we are likely to see a lot of issues reported by users with the backward-incompatible change.
     7Maybe no code change is needed though, rather just a note added to the documentation.
     8
     9Even if we only document the caveat for the plugin, when adding the feature to Trac (trac:#12299) maybe we should consider a more robust approach. I have never really liked that plugins are implicitly enabled when added to the `plugins` directory. Maybe that behavior should be changed for Trac 1.2 and require that all plugins be explicitly enabled? I hesitate to suggest that though, because unless we can automatically populate the components section on upgrade, then we are likely to see a lot of issues reported by users due to the backward-incompatible change.