Changes between Version 1 and Version 2 of Ticket #12729, comment 5


Ignore:
Timestamp:
Apr 22, 2020, 6:09:59 PM (4 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12729, comment 5

    v1 v2  
    11Initial feedback:
    2 * The `N:M` syntax is nice, but we could start also the `start` and `end` keywords like IncludeSourcePartialPlugin#Description. And/or we could use a keyword like `lines=N:M`.
    3 * For line numbering, I definitely think we should use a keyword: `lineno=True`.
     2* The `N:M` syntax is nice, but we could also support the `start` and `end` keywords like IncludeSourcePartialPlugin#Description. And/or, I think we should consider using TracLinks syntax like `@200:27-30`, where `200` is the rev and `27-30` are the lines. We already support a peg revision like `@200`.
     3* For line numbering, I definitely prefer a keyword: `lineno=True`.
     4* Are you planning to continue developing IncludeSourcePartialPlugin? Or finalize that code and switch over to IncludeMacro development? I've granted you commit access to IncludeMacro.
    45
    56Thoughts?