Opened 3 years ago

Closed 3 years ago

Install WikiAutoCompletePlugin to trac-hacks.org

Reported by: Owned by: Ryan J Ollos Ryan J Ollos normal TracHacks normal Steffen Hoffmann, Ryan J Ollos, Jun Omae, Peter Suter

Description

The WikiAutoCompletePlugin looks very useful, and there's been a lot of development activity, so I was considering installing it to trac-hacks.org. Thoughts?

comment:1 Changed 3 years ago by Ryan J Ollos

Owner: changed from Michael Renzmann to Ryan J Ollos new → assigned

comment:2 Changed 3 years ago by Peter Suter

That sounds nice.

I wonder if it would noticeably impact server performance due to the additional requests. You might want to keep an eye on that. Jun added some caching strategies in #12954.

Version 0, edited 3 years ago by Peter Suter (next)

comment:3 follow-up:  4 Changed 3 years ago by Jun Omae

Fine by me. I'm using this plugin with the following patch on my production environments.

IE 8 doesn't support Array.prototype.forEach, which is used by jquery.textcomplete.js. In my production environments, javascript errors are captured and reported using windows.onerror. The patch would prevent noisy errors about forEach.

• wikiautocomplete/htdocs/js/wikiautocomplete.js

diff --git a/wikiautocomplete/htdocs/js/wikiautocomplete.js b/wikiautocomplete/htdocs/
index ea6c607..4c966c1 100644
 a jQuery(document).ready(function(\$) { if (Array.prototype.forEach === undefined) return; var cache = {}; function escape_newvalue(value) {

comment:4 in reply to:  3 ; follow-up:  6 Changed 3 years ago by Ryan J Ollos

Fine by me. I'm using this plugin with the following patch on my production environments.

Is there any downside to committing that patch to the WikiAutoCompletePlugin repository?

comment:5 Changed 3 years ago by Ryan J Ollos

Resolution: → fixed assigned → closed

Installed and seems to be working well.

comment:6 in reply to:  4 ; follow-up:  7 Changed 3 years ago by Jun Omae

Fine by me. I'm using this plugin with the following patch on my production environments.

Is there any downside to committing that patch to the WikiAutoCompletePlugin repository?

No harm to commit. Also, that works fine on my environment.

comment:7 in reply to:  6 Changed 3 years ago by Peter Suter

Fine by me. I'm using this plugin with the following patch on my production environments.

Is there any downside to committing that patch to the WikiAutoCompletePlugin repository?

No harm to commit. Also, that works fine on my environment.

Modify Ticket

Change Properties