Opened 5 years ago

Last modified 18 months ago

#13263 closed defect

Notification doesn't work — at Version 2

Reported by: tim.ward@… Owned by: osimons
Priority: normal Component: XmlRpcPlugin
Severity: normal Keywords: Notification
Cc: Olemis Lang Trac Release: 1.2

Description (last modified by Ryan J Ollos)

When setting notify=True on the ticket.update call the INotificationSubscriber plugins don't appear to get called.

It looks like notify=True results in calling some old, outdated, Trac notification system which works off some hard-coded stuff in trac.ini, rather than the current notification system which is configurable by user preferences.

So if you're using the new user-configurable notification system all you get if you set notify=True for ticket.update is

Trac[compat] INFO: no recipient for a ticket notification

in the log, and no emails.

Change History (2)

comment:1 Changed 5 years ago by anonymous

What seems to work is, in ticket.py change

                tn = TicketNotifyEmail(self.env)
                tn.notify(t, newticket=False, modtime=when)

to

                event = TicketChangeEvent( 'changed', t, when, author, comment )
                NotificationSystem( self.env ).notify( event )

I haven't attempted to do the same for create (I've only tried it for update) and I haven't looked at whether there are any unit tests covering this area.

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:2 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)
Note: See TracTickets for help on using tickets.