Opened 5 years ago

Last modified 5 years ago

#13531 closed defect

AccountManager SvnServePasswordStore doesn't adhere correctly to the IPasswordStore store API. — at Initial Version

Reported by: Mat Cross Owned by: Ryan J Ollos
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.2

Description

Updating from 0.4.4 to 0.5.0 (Trac 1.2.3), registering new users to an svnserve store always results in error message "Password for user foo existed, couldn't create" and the user/pass line still being added to the store file.

One can see in the svnserve.py source that set_password always returns None. On further inspection the implementation of delete_user looks incorrect too.

Change History (1)

Changed 5 years ago by Mat Cross

Attachment: my.diff​ added

Patch for a proposed fix (against trunk), including a test suite.

Note: See TracTickets for help on using tickets.