Opened 17 years ago
Closed 12 years ago
#2032 closed defect (worksforme)
[Patch] SimpleTicketPlugin not playing well with PrivateTicketPlugin — at Version 5
Reported by: | Owned by: | Ryan J Ollos | |
---|---|---|---|
Priority: | normal | Component: | SimpleTicketPlugin |
Severity: | minor | Keywords: | |
Cc: | Ryan J Ollos, falkb | Trac Release: | 0.10 |
Description (last modified by )
Using PrivateTicketPlugin
and giving users one of the added permissions instead of TICKET_VIEW causes a problem in redirect():
def redirect(self, dest): if dest.startswith(self.env.href.ticket()): if not (self.req.perm.has_permission('TICKET_VIEW'): self.req.redirect(self.env.href.simpleticket())
TICKET_VIEW_REPORTER and TICKET_VIEW_SELF are the only ones to be added because the other permissions do not concern the creation of ticket.
Patch attached.
Change History (6)
Changed 17 years ago by
Attachment: | simpleticket.patch added |
---|
comment:1 Changed 17 years ago by
Simply hard coding those in is not a terribly good solution to me. Using the new security stuff in 0.11 (once PrivateTickets is ported) this should be much cleaner.
comment:2 Changed 15 years ago by
Cc: | Ryan J Ollos added; anonymous removed |
---|
comment:3 Changed 14 years ago by
Summary: | SimpleTicketPlugin not playing well with PrivateTicketPlugin → [Patch] SimpleTicketPlugin not playing well with PrivateTicketPlugin |
---|
comment:4 Changed 12 years ago by
Cc: | falkb added |
---|---|
Owner: | changed from Noah Kantrowitz to Ryan J Ollos |
Status: | new → assigned |
I'll be testing r10990 with the PrivateTicketsPlugin to see if there are any outstanding issues still.
comment:5 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Resolution: | → worksforme |
Status: | assigned → closed |
I've tested with Trac 0.12.2 and SimpleTicketPlugin is working well with PrivateTicketsPlugin. There is no reference to the TICKET_VIEW
in the 0.11 version of SimpleTicketPlugin.
Patch file